This bug intends to implement the ewk_view_fullscreen_enter() function as part of UIProcess' ewk_view API. This enables application to request for fullscreen (i.e. user triggered F11 key).
Created attachment 185138 [details] Patch Proposed patch (requires patch from bug 108121).
Comment on attachment 185138 [details] Patch Attachment 185138 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16160927
Comment on attachment 185138 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185138&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:944 > + impl->page()->fullScreenManager()->requestEnterFullScreen(); Please use C API in new patches. We are in the process of porting everything to the C API. > Source/WebKit2/UIProcess/API/efl/ewk_view.h:802 > +EAPI Eina_Bool ewk_view_fullscreen_enter(Evas_Object *o); Missing API test.
Created attachment 185241 [details] Patch Simpler approach using native API suggested by Christophe
Comment on attachment 185241 [details] Patch Did you make sure that pressing "ESC" does not exit fullscreen if it has been triggered using F11?
(In reply to comment #5) > (From update of attachment 185241 [details]) > Did you make sure that pressing "ESC" does not exit fullscreen if it has been triggered using F11? You're right, the browser crashes if ESC is pressed (my bad). However to avoid checking for FullScreen API directly, I'll add a boolean that specifies whether the fullscreen mode was activated by F11 or JS user gesture. Do you agree on this approach?
Hmm, ewk_view_fullscreen_exit() should not crash if full screen was not triggered by fullscreen API. We should probably fix ewk_view_fullscreen_exit() instead of adding a boolean.
(In reply to comment #7) > Hmm, ewk_view_fullscreen_exit() should not crash if full screen was not triggered by fullscreen API. We should probably fix ewk_view_fullscreen_exit() instead of adding a boolean. Agreed, so this bug's implementation is correct. This crash is now handled on bug 108201.
Comment on attachment 185241 [details] Patch LGTM.
Comment on attachment 185241 [details] Patch Trivial enough. r+
Comment on attachment 185241 [details] Patch Clearing flags on attachment: 185241 Committed r141152: <http://trac.webkit.org/changeset/141152>
All reviewed patches have been landed. Closing bug.