Bug 108116 - Handle createShadowSubtree inside of ensureUserAgentShadowRoot
Summary: Handle createShadowSubtree inside of ensureUserAgentShadowRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-28 14:30 PST by Elliott Sprehn
Modified: 2013-01-28 23:48 PST (History)
14 users (show)

See Also:

Attachments
Patch (32.08 KB, patch)
2013-01-28 14:33 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch for landing (32.16 KB, patch)
2013-01-28 19:54 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2013-01-28 14:30:12 PST 
Handle createShadowSubtree inside of ensureUserAgentShadowRoot
Comment 1 Elliott Sprehn 2013-01-28 14:33:10 PST 
Created attachment 185065 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2013-01-28 14:47:08 PST 
Comment on attachment 185065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185065&action=review

Lovely.

> Source/WebCore/dom/Element.cpp:1495
> +    ShadowRoot* shadowRoot = ShadowRoot::create(this, ShadowRoot::UserAgentShadowRoot, ASSERT_NO_EXCEPTION).get();

Ugh, we should totally get rid of this nasty factory. It just looks bad, handing off a PassRefPtr to immediately get it unwrapped.
Comment 3 Elliott Sprehn 2013-01-28 18:29:52 PST 
Comment on attachment 185065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185065&action=review

>> Source/WebCore/dom/Element.cpp:1495
>> +    ShadowRoot* shadowRoot = ShadowRoot::create(this, ShadowRoot::UserAgentShadowRoot, ASSERT_NO_EXCEPTION).get();
> 
> Ugh, we should totally get rid of this nasty factory. It just looks bad, handing off a PassRefPtr to immediately get it unwrapped.

Yeah, I have a whole series of patches to clean this up.
Comment 4 Elliott Sprehn 2013-01-28 19:54:18 PST 
Created attachment 185137 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-01-28 23:48:52 PST 
Comment on attachment 185137 [details]
Patch for landing

Clearing flags on attachment: 185137

Committed r141066: <http://trac.webkit.org/changeset/141066>
Comment 6 WebKit Review Bot 2013-01-28 23:48:58 PST 
All reviewed patches have been landed.  Closing bug.