Bug 108104 - [BlackBerry] Small animated zoom level adjustments are unnecessary
Summary: [BlackBerry] Small animated zoom level adjustments are unnecessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-28 12:45 PST by Andrew Lo
Modified: 2013-01-28 20:43 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.97 KB, patch)
2013-01-28 14:11 PST, Andrew Lo
no flags Details | Formatted Diff | Diff
Patch (3.30 KB, patch)
2013-01-28 14:34 PST, Andrew Lo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2013-01-28 12:45:41 PST
We should not animate a zoom level change when the zoom level change is small.
Comment 1 Andrew Lo 2013-01-28 14:11:36 PST
Created attachment 185060 [details]
Patch
Comment 2 Andrew Lo 2013-01-28 14:34:56 PST
Created attachment 185067 [details]
Patch
Comment 3 Rob Buis 2013-01-28 14:37:00 PST
Comment on attachment 185067 [details]
Patch

LGTM.
Comment 4 Build Bot 2013-01-28 15:51:29 PST
Comment on attachment 185067 [details]
Patch

Attachment 185067 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16160742

New failing tests:
http/tests/inspector/resource-tree/resource-request-content-while-loading.html
Comment 5 Rob Buis 2013-01-28 17:24:45 PST
Comment on attachment 185067 [details]
Patch

Retrying.
Comment 6 WebKit Review Bot 2013-01-28 20:43:20 PST
Comment on attachment 185067 [details]
Patch

Clearing flags on attachment: 185067

Committed r141043: <http://trac.webkit.org/changeset/141043>
Comment 7 WebKit Review Bot 2013-01-28 20:43:24 PST
All reviewed patches have been landed.  Closing bug.