WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108101
PLATFORM(IOS) should come before __MAC_OS_X_VERSION_MIN_REQUIRED
https://bugs.webkit.org/show_bug.cgi?id=108101
Summary
PLATFORM(IOS) should come before __MAC_OS_X_VERSION_MIN_REQUIRED
Pratik Solanki
Reported
2013-01-28 12:32:39 PST
__MAC_OS_X_VERSION_MIN_REQUIRED is not defined on iOS so code like the following fails to achieve its intended purpose #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 && !PLATFORM(IOS) It should be updated to #if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
Attachments
Patch
(6.85 KB, patch)
2013-01-28 12:36 PST
,
Pratik Solanki
benjamin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pratik Solanki
Comment 1
2013-01-28 12:36:08 PST
Created
attachment 185036
[details]
Patch
David Kilzer (:ddkilzer)
Comment 2
2013-01-28 12:38:18 PST
I fixed this as a BUILD FIX in
r140988
. <
http://trac.webkit.org/changeset/140988
>
Pratik Solanki
Comment 3
2013-01-28 12:40:11 PST
Yup. This is fixed.
Pratik Solanki
Comment 4
2013-01-28 12:42:30 PST
Umm.
r140988
doesn't cover all the cases. There's a few more places that need to be fixed.
Pratik Solanki
Comment 5
2013-01-28 16:20:10 PST
Committed
r141025
: <
http://trac.webkit.org/changeset/141025
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug