Bug 108096 - Don't use threaded HTML parser for data: URLs
Summary: Don't use threaded HTML parser for data: URLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-01-28 11:40 PST by Tony Gentilcore
Modified: 2013-01-28 12:37 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.83 KB, patch)
2013-01-28 11:41 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch for landing (2.00 KB, patch)
2013-01-28 11:47 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2013-01-28 11:40:19 PST
Don't use threaded HTML parser for data: URLs
Comment 1 Tony Gentilcore 2013-01-28 11:41:53 PST
Created attachment 185023 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-01-28 11:44:30 PST
Comment on attachment 185023 [details]
Patch

You should add a comment as to why, as this if is getting complicated enough to cause future confusion.

// We force the main-thread parser for about:blank, javascript: and data: urls for compatibility with historical synchronous loading/parsing behavior of those schemes.
Comment 3 Tony Gentilcore 2013-01-28 11:47:17 PST
Created attachment 185024 [details]
Patch for landing
Comment 4 WebKit Review Bot 2013-01-28 12:37:44 PST
Comment on attachment 185024 [details]
Patch for landing

Clearing flags on attachment: 185024

Committed r140992: <http://trac.webkit.org/changeset/140992>
Comment 5 WebKit Review Bot 2013-01-28 12:37:47 PST
All reviewed patches have been landed.  Closing bug.