Bug 108095 - Remove USE(OS_RANDOMNESS)
Summary: Remove USE(OS_RANDOMNESS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 108125
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-28 11:13 PST by Laszlo Gombos
Modified: 2013-05-10 18:26 PDT (History)
9 users (show)

See Also:

Attachments
proposed change (10.81 KB, patch)
2013-05-10 10:41 PDT, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2013-01-28 11:13:14 PST 
USE_OS_RANDOMNESS seems to be always set, so we should consider removing the guard.
Comment 1 Laszlo Gombos 2013-01-28 11:19:04 PST 
Before proceeding with this work, I  would like to get a confirmation that OS(QNX) is always set when PLATFORM(BLACKBERRY) set.

Can someone help me to get a confirmation on this ? 

If PLATFORM(BLACKBERRY) assumes OS(QNX), that would mean that OS(UNIX) is defined, which would mean that USE(OS_RANDOMNESS) is set.
Comment 2 Yong Li 2013-01-28 11:29:33 PST 
(In reply to comment #1)
> Before proceeding with this work, I  would like to get a confirmation that OS(QNX) is always set when PLATFORM(BLACKBERRY) set.
> 
> Can someone help me to get a confirmation on this ? 
> 
> If PLATFORM(BLACKBERRY) assumes OS(QNX), that would mean that OS(UNIX) is defined

Confirmed.
Comment 3 Laszlo Gombos 2013-05-10 10:41:32 PDT 
Created attachment 201361 [details]
proposed change

Notice that WTF_USE_OS_RANDOMNESS was set to 1 for both OS(UNIX) and OS(WINDOWS). As far as I know OS(UNIX) and OS(WINDOWS) covers all the supported platforms on trunk.
Comment 4 WebKit Commit Bot 2013-05-10 18:26:21 PDT 
Comment on attachment 201361 [details]
proposed change

Clearing flags on attachment: 201361

Committed r149921: <http://trac.webkit.org/changeset/149921>
Comment 5 WebKit Commit Bot 2013-05-10 18:26:24 PDT 
All reviewed patches have been landed.  Closing bug.