WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108089
"clang: warning: not using the clang compiler for C++ inputs" due to hard-coding of /usr/bin/clang in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=108089
Summary
"clang: warning: not using the clang compiler for C++ inputs" due to hard-cod...
sideshowbarker
Reported
2013-01-28 09:37:22 PST
http://trac.webkit.org/changeset/140925
for
bug 107984
changed Source/WebCore/WebCore.gyp/WebCore.gyp so that it now hardcodes "/usr/bin/clang" as an argument for --preprocessor switch that's fed to the part of the build that preprocesses the bindings idl files. In my OSX 10.6.8 environment, that change causes the build to generate hundreds of "clang: warning: not using the clang compiler for C++ inputs" messages. Why not just have "clang" there instead of "/usr/bin/clang"? That way you could just have this part of the build using the clang that the rest of the build uses; e.g., if I have my environment set up for building Chromium with clang in $CHROME/src/third_party/llvm-build/Release+Asserts/bin the idl preprocessing would use that clang too.
Attachments
Patch
(2.05 KB, patch)
2013-01-28 12:32 PST
,
Tony Chang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nico Weber
Comment 1
2013-01-28 09:49:07 PST
Install Xcode 4.2 and install the command line tools. Then you should be all set.
sideshowbarker
Comment 2
2013-01-28 09:58:32 PST
(In reply to
comment #1
)
> Install Xcode 4.2 and install the command line tools. Then you should be all set.
If Xcode 4.2 is the latest, it's not possible to install it in a OSX 10.6.8. I tried it before and got a message saying as much. Anyway, I'm able to build Chromium fine in my 10.6 without needing Xcode 4.2, and I think it's reasonable to expect that dependencies on Xcode 4.2 shouldn't be introduced unless they're really necessary.
Tony Chang
Comment 3
2013-01-28 10:30:23 PST
Nico: Maybe I should have OSX use /usr/bin/gcc? That would actually be more like the Apple Mac build. When /usr/bin/gcc goes away, we'll have to update both builds.
Nico Weber
Comment 4
2013-01-28 12:17:22 PST
Fine with me, but I'm not sure how much longer we're going to support buildling with Xcode 3.2.6 anyhow. And I believe Xcode 4.2 includes a capable clang and is available for 10.6 (that's what I have installed on my 10.6 box).
Tony Chang
Comment 5
2013-01-28 12:32:26 PST
Created
attachment 185034
[details]
Patch
Nico Weber
Comment 6
2013-01-28 12:38:59 PST
lgtm / meh.
WebKit Review Bot
Comment 7
2013-01-28 14:07:32 PST
Comment on
attachment 185034
[details]
Patch Clearing flags on attachment: 185034 Committed
r141007
: <
http://trac.webkit.org/changeset/141007
>
WebKit Review Bot
Comment 8
2013-01-28 14:07:36 PST
All reviewed patches have been landed. Closing bug.
sideshowbarker
Comment 9
2013-01-28 21:23:45 PST
(In reply to
comment #4
)
> Fine with me, but I'm not sure how much longer we're going to support buildling with Xcode 3.2.6 anyhow. And I believe Xcode 4.2 includes a capable clang and is available for 10.6 (that's what I have installed on my 10.6 box).
Not to beat this into the ground, but I went to
https://developer.apple.com/downloads/index.action?name=Xcode
to try to download it but the only Xcode 4.2 download there is specifically labeled "Xcode 4.2 for Lion". (The Xcode 4.1 and 4.3 downloads are labeled that way too.) So if you're using it with 10.6, I assume that despite how it's labeled it's actually possible to install it and run it under 10.6, so I'll give it a try. Also, I get the main point and will make some time soon to get my OS updated to Mountain Lion. Anyway, thanks for the responses and fix on this bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug