RESOLVED FIXED 108087
Web Inspector: in inspector-protocol tests do not swallow errors 
https://bugs.webkit.org/show_bug.cgi?id=108087
Summary Web Inspector: in inspector-protocol tests do not swallow errors
Peter Rybin
Reported 2013-01-28 09:05:55 PST
If function the test function hasn't been found or failed to be compiled, test will timeout. Kill test in this case and provide error message.
Attachments
Patch (2.54 KB, patch)
2013-01-28 09:09 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (2.57 KB, patch)
2013-01-29 03:39 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2013-01-28 09:09:48 PST
Created attachment 184993 [details] Patch
Yury Semikhatsky
Comment 2 2013-01-29 03:34:20 PST
Comment on attachment 184993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184993&action=review > LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:89 > + if (typeof testFunction == "function") { == -> ===
Peter Rybin
Comment 3 2013-01-29 03:39:42 PST
Created attachment 185214 [details] Patch
Peter Rybin
Comment 4 2013-01-29 03:40:52 PST
(In reply to comment #2) > (From update of attachment 184993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184993&action=review > > > LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:89 > > + if (typeof testFunction == "function") { > > == -> === Done
WebKit Review Bot
Comment 5 2013-01-29 04:58:35 PST
Comment on attachment 185214 [details] Patch Clearing flags on attachment: 185214 Committed r141100: <http://trac.webkit.org/changeset/141100>
WebKit Review Bot
Comment 6 2013-01-29 04:58:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.