Bug 108087 - Web Inspector: in inspector-protocol tests do not swallow errors
Summary: Web Inspector: in inspector-protocol tests do not swallow errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-28 09:05 PST by Peter Rybin
Modified: 2013-01-29 04:58 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2013-01-28 09:09 PST, Peter Rybin 		no flags Details | Formatted Diff | Diff
Patch (2.57 KB, patch)
2013-01-29 03:39 PST, Peter Rybin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2013-01-28 09:05:55 PST 
If function the test function hasn't been found or failed to be compiled, test will timeout.
Kill test in this case and provide error message.
Comment 1 Peter Rybin 2013-01-28 09:09:48 PST 
Created attachment 184993 [details]
Patch
Comment 2 Yury Semikhatsky 2013-01-29 03:34:20 PST 
Comment on attachment 184993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184993&action=review

> LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:89
> +        if (typeof testFunction == "function") {

== -> ===
Comment 3 Peter Rybin 2013-01-29 03:39:42 PST 
Created attachment 185214 [details]
Patch
Comment 4 Peter Rybin 2013-01-29 03:40:52 PST 
(In reply to comment #2)
> (From update of attachment 184993 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184993&action=review
> 
> > LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:89
> > +        if (typeof testFunction == "function") {
> 
> == -> ===

Done
Comment 5 WebKit Review Bot 2013-01-29 04:58:35 PST 
Comment on attachment 185214 [details]
Patch

Clearing flags on attachment: 185214

Committed r141100: <http://trac.webkit.org/changeset/141100>
Comment 6 WebKit Review Bot 2013-01-29 04:58:39 PST 
All reviewed patches have been landed.  Closing bug.