Bug 108075 - Web Inspector: Inherit SidebarPane from View
Summary: Web Inspector: Inherit SidebarPane from View
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vladislav Kaznacheev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-28 05:48 PST by Vladislav Kaznacheev
Modified: 2013-01-28 08:16 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.88 KB, patch)
2013-01-28 06:10 PST, Vladislav Kaznacheev 		no flags Details | Formatted Diff | Diff
Patch (8.58 KB, patch)
2013-01-28 07:09 PST, Vladislav Kaznacheev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladislav Kaznacheev 2013-01-28 05:48:16 PST 
WebInspector.SidebarPane class currently inherits from WebInspector.Object and requires special handling in the client code that otherwise mostly deals with WevInspector.View instances. Inheriting WebInspector.SidebarPane from WebInspector.View will streamline the code and simplify further enhancements to sidebar panes.
Comment 1 Vladislav Kaznacheev 2013-01-28 06:10:28 PST 
Created attachment 184975 [details]
Patch
Comment 2 Vladislav Kaznacheev 2013-01-28 07:09:35 PST 
Created attachment 184979 [details]
Patch
Comment 3 WebKit Review Bot 2013-01-28 08:15:57 PST 
Comment on attachment 184979 [details]
Patch

Clearing flags on attachment: 184979

Committed r140968: <http://trac.webkit.org/changeset/140968>
Comment 4 WebKit Review Bot 2013-01-28 08:16:00 PST 
All reviewed patches have been landed.  Closing bug.