Bug 108072 - Web Inspector: [CPU Profile] Taking profile crashes renderer.
Summary: Web Inspector: [CPU Profile] Taking profile crashes renderer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-28 03:40 PST by Eugene Klyuchnikov
Modified: 2013-01-29 03:57 PST (History)
14 users (show)

See Also:

Attachments
Patch (4.52 KB, patch)
2013-01-28 04:03 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2013-01-28 03:40:54 PST 
This regression is caused by https://bugs.webkit.org/show_bug.cgi?id=107674

More precisely: in file ScriptProfiler.cpp it is explicitly declared that "start" and "stop" could be invoked with state == 0 (see "startForPage", "stopForPage", etc.)
Accessing "isolate" of a null pointer causes crashes.
Comment 1 Eugene Klyuchnikov 2013-01-28 04:03:41 PST 
Created attachment 184967 [details]
Patch
Comment 2 Yury Semikhatsky 2013-01-28 04:31:49 PST 
Comment on attachment 184967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184967&action=review

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:80
>      const v8::CpuProfile* profile = state ?

In which cases it the state is 0?
Comment 3 WebKit Review Bot 2013-01-29 03:57:15 PST 
Comment on attachment 184967 [details]
Patch

Clearing flags on attachment: 184967

Committed r141094: <http://trac.webkit.org/changeset/141094>
Comment 4 WebKit Review Bot 2013-01-29 03:57:19 PST 
All reviewed patches have been landed.  Closing bug.