Bug 108069 – INPUT_MULTIPLE_FIELDS_UI: The content should not overflow the <input> boundary

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Created attachment 184958 [details]
screenshot

http://code.google.com/p/chromium/issues/detail?id=172029

If small width/height is specified to an <input>, its content overflows. See the attachment

[Kent Tamura]

Created attachment 184960 [details]
WIP

[Early Warning System Bot]

Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16152549

[Early Warning System Bot]

Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16159019

[EFL EWS Bot]

Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16156543

[Peter Beverloo (cr-android ews)]

Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16153594

[Build Bot]

Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16155554

[Build Bot]

Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16155552

[Build Bot]

Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16155555

[WebKit Review Bot]

Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16149651

New failing tests:
fast/forms/month/month-appearance-basic.html
platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html
fast/forms/time/time-appearance-basic.html
fast/forms/datetimelocal/datetimelocal-appearance-basic.html
fast/forms/week/week-appearance-basic.html

[Kent Tamura]

Created attachment 185110 [details]
WIP 2

[Kent Tamura]

Created attachment 185198 [details]
Patch

[Kent Tamura]

P1 because this is a release blocker for Chrome.

[Kent Tamura]

Created attachment 185207 [details]
Patch 2

[Kentaro Hara]

morrita-san: would you take a look?

[Kent Tamura]

Keishi, can you do informal review?

[Hajime Morrita]

Comment on attachment 185207 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=185207&action=review

> Source/WebCore/html/HTMLInputElement.cpp:1981
> +    RefPtr<RenderStyle> style = RenderStyle::clone(originalStyle.get());

We could get rid of this cloning if the style's direction and locale's direction is the same (in most cases it is I guess.)

[Kent Tamura]

Comment on attachment 185207 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=185207&action=review

>> Source/WebCore/html/HTMLInputElement.cpp:1981
>> +    RefPtr<RenderStyle> style = RenderStyle::clone(originalStyle.get());
> 
> We could get rid of this cloning if the style's direction and locale's direction is the same (in most cases it is I guess.)

That's right.  I'll change so.

[Kent Tamura]

Committed r141195: <http://trac.webkit.org/changeset/141195>