Bug 108069 - INPUT_MULTIPLE_FIELDS_UI: The content should not overflow the <input> boundary
Summary: INPUT_MULTIPLE_FIELDS_UI: The content should not overflow the <input> boundary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-28 02:05 PST by Kent Tamura
Modified: 2013-01-29 18:06 PST (History)
9 users (show)

See Also:

Attachments
screenshot (19.31 KB, image/png)
2013-01-28 02:05 PST, Kent Tamura 		no flags Details
WIP (133.64 KB, patch)
2013-01-28 02:15 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
WIP 2 (134.20 KB, patch)
2013-01-28 17:03 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch (138.70 KB, patch)
2013-01-29 01:38 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 2 (138.84 KB, patch)
2013-01-29 02:36 PST, Kent Tamura 		morrita: review+
tkent: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2013-01-28 02:05:59 PST 
Created attachment 184958 [details]
screenshot

http://code.google.com/p/chromium/issues/detail?id=172029

If small width/height is specified to an <input>, its content overflows. See the attachment
Comment 1 Kent Tamura 2013-01-28 02:15:40 PST 
Created attachment 184960 [details]
WIP
Comment 2 Early Warning System Bot 2013-01-28 02:23:43 PST 
Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16152549
Comment 3 Early Warning System Bot 2013-01-28 02:24:17 PST 
Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16159019
Comment 4 EFL EWS Bot 2013-01-28 02:27:06 PST 
Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16156543
Comment 5 Peter Beverloo (cr-android ews) 2013-01-28 02:32:43 PST 
Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16153594
Comment 6 Build Bot 2013-01-28 02:35:00 PST 
Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16155554
Comment 7 Build Bot 2013-01-28 02:43:55 PST 
Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16155552
Comment 8 Build Bot 2013-01-28 03:06:31 PST 
Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16155555
Comment 9 WebKit Review Bot 2013-01-28 05:05:02 PST 
Comment on attachment 184960 [details]
WIP

Attachment 184960 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16149651

New failing tests:
fast/forms/month/month-appearance-basic.html
platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html
fast/forms/time/time-appearance-basic.html
fast/forms/datetimelocal/datetimelocal-appearance-basic.html
fast/forms/week/week-appearance-basic.html
Comment 10 Kent Tamura 2013-01-28 17:03:26 PST 
Created attachment 185110 [details]
WIP 2
Comment 11 Kent Tamura 2013-01-29 01:38:04 PST 
Created attachment 185198 [details]
Patch
Comment 12 Kent Tamura 2013-01-29 01:50:57 PST 
P1 because this is a release blocker for Chrome.
Comment 13 Kent Tamura 2013-01-29 02:36:21 PST 
Created attachment 185207 [details]
Patch 2
Comment 14 Kentaro Hara 2013-01-29 03:19:37 PST 
morrita-san: would you take a look?
Comment 15 Kent Tamura 2013-01-29 04:32:46 PST 
Keishi, can you do informal review?
Comment 16 Hajime Morrita 2013-01-29 16:18:14 PST 
Comment on attachment 185207 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=185207&action=review

> Source/WebCore/html/HTMLInputElement.cpp:1981
> +    RefPtr<RenderStyle> style = RenderStyle::clone(originalStyle.get());

We could get rid of this cloning if the style's direction and locale's direction is the same (in most cases it is I guess.)
Comment 17 Kent Tamura 2013-01-29 17:37:33 PST 
Comment on attachment 185207 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=185207&action=review

>> Source/WebCore/html/HTMLInputElement.cpp:1981
>> +    RefPtr<RenderStyle> style = RenderStyle::clone(originalStyle.get());
> 
> We could get rid of this cloning if the style's direction and locale's direction is the same (in most cases it is I guess.)

That's right.  I'll change so.
Comment 18 Kent Tamura 2013-01-29 18:06:57 PST 
Committed r141195: <http://trac.webkit.org/changeset/141195>