RESOLVED FIXED 108068
Web Inspector: [Regression] Search all sources should not search across service projects. 
https://bugs.webkit.org/show_bug.cgi?id=108068
Summary Web Inspector: [Regression] Search all sources should not search across servi...
Vsevolod Vlasov
Reported 2013-01-28 02:01:00 PST
Patch to follow.
Attachments
Patch (2.36 KB, patch)
2013-01-28 04:18 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2013-01-28 04:18:26 PST
Created attachment 184969 [details] Patch
WebKit Review Bot
Comment 2 2013-01-28 04:49:14 PST
Comment on attachment 184969 [details] Patch Clearing flags on attachment: 184969 Committed r140966: <http://trac.webkit.org/changeset/140966>
WebKit Review Bot
Comment 3 2013-01-28 04:49:18 PST
All reviewed patches have been landed. Closing bug.
johnjbarton
Comment 4 2013-01-28 14:49:59 PST
Global "Search sources" is broken, I guess we don't have test coverage for it? > Source/WebCore/inspector/front-end/ScriptsSearchScope.js:126 > + uiSourceCodes = this._uiSourceCodes.concat(projects[i].uiSourceCodes()); I guess you meant uiSourceCodes = uiSourceCodes.concat(projects[i].uiSourceCodes()); since there is no this._uiSourceCodes
Vsevolod Vlasov
Comment 5 2013-01-28 23:51:14 PST
I'll fix it and add a test in https://bugs.webkit.org/show_bug.cgi?id=108157.
Note You need to log in before you can comment on or make changes to this bug.