Bug 108063 - Change test expectation to ensure that seamless iframes do not inherit editability.
Summary: Change test expectation to ensure that seamless iframes do not inherit editab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-28 01:02 PST by Mike West
Modified: 2013-01-28 01:40 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.56 KB, patch)
2013-01-28 01:07 PST, Mike West
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-01-28 01:02:48 PST
Based on the conversation at https://bugs.webkit.org/show_bug.cgi?id=95890#c3, I believe that the expectation in `fast/frames/seamless/seamless-inherited-document-style.html` regarding `-webkit-user-modify` is incorrect. We don't want to inherit `-webkit-user-modify` from the IFrame, for the same reasons that we don't want to inherit the `contenteditable` attribute.
Comment 1 Mike West 2013-01-28 01:07:09 PST
Created attachment 184948 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-01-28 01:12:20 PST
Comment on attachment 184948 [details]
Patch

If this is what the spec'rs say, then sure. :)
Comment 3 Mike West 2013-01-28 01:31:57 PST
Comment on attachment 184948 [details]
Patch

(In reply to comment #2)
> (From update of attachment 184948 [details])
> If this is what the spec'rs say, then sure. :)

This is what you "r=me"'d in the comment I linked up. :)

The spec notes that contenteditable on the iframe shouldn't be inherited, and Hixie and Ojan were clear on extending that point to `-webkit-user-modify` in https://bugs.webkit.org/show_bug.cgi?id=95890. I'm comfy with this change. :)
Comment 4 WebKit Review Bot 2013-01-28 01:40:30 PST
Comment on attachment 184948 [details]
Patch

Clearing flags on attachment: 184948

Committed r140954: <http://trac.webkit.org/changeset/140954>
Comment 5 WebKit Review Bot 2013-01-28 01:40:34 PST
All reviewed patches have been landed.  Closing bug.