Bug 108047 - [Shadow] mouseIsReleasedOnPressedElement in EventHandler should not check ShadowRoot type
Summary: [Shadow] mouseIsReleasedOnPressedElement in EventHandler should not check Sha...
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 107233
Blocks: 59805
  Show dependency treegraph
Reported: 2013-01-27 20:43 PST by Shinya Kawanaka
Modified: 2019-02-06 09:18 PST (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2013-01-27 20:43:49 PST
Basically we should not check ShadowRoot type.
However, otherwise it will break <input type="range">
Maybe we have to consider what the real solution for this issue.
Comment 1 Daniel Bates 2015-06-08 17:40:27 PDT
mouseIsReleasedOnPressedElement() was removed in the patch for bug #145774.

I do not understand the need to special case the logic for dispatching a DOM click event to a user-agent shadow DOM. It seems sufficient to use the same logic for deciding when to dispatch a DOM click event for both kinds of shadow DOM tree so long as we take care to dispatch the DOM click event to the appropriate node. Specifically, we should use the same criterion for determining whether to dispatch a DOM click event for non-shadow tree nodes as we do we shadow tree nodes(*) with the only exception that we explicitly dispatch the click event at the shadow host element if the mouse press and mouse release occur within the same shadow tree and not on the same shadow tree element (which would have been handled by (*)).
Comment 2 Lucas Forschler 2019-02-06 09:18:55 PST
Mass move bugs into the DOM component.