Bug 108028 - REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
Summary: REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / buil...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Farler
Keywords: Regression
Depends on:
Reported: 2013-01-27 01:21 PST by Mark Rowe (bdash)
Modified: 2013-01-27 20:24 PST (History)
3 users (show)

See Also:

Patch (10.37 KB, patch)
2013-01-27 03:33 PST, David Farler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2013-01-27 01:21:51 PST
Prior to r140912 the following worked and had the expected behavior:

> make debug ARGS="ARCHS='x86_64 i386' ONLY_ACTIVE_ARCH=NO"

> ./Tools/Scripts/build-webkit ARCHS='$(ARCHS_STANDARD_32_64_BIT)' ONLY_ACTIVE_ARCH=NO

The former now results in completely bogus arguments being passed to xcodebuild:

> xcodebuild -configuration Debug -sdk / -arch  -arch  -arch  -arch x86_64 

As does the latter:

> xcodebuild -project WTF.xcodeproj -configuration Debug -sdk / -arch  -arch $( -arch ) ONLY_ACTIVE_ARCH=NO

This is breaking the nightly builds, since they pass explicit ARCHS flags to the build scripts, and it also breaks our established method of building for non-default / multiple architectures.

The fact we're now passing an explicit "-sdk" argument for OS X builds is also not good, but isn't a cause of this breakage.
Comment 1 David Farler 2013-01-27 03:30:02 PST
I think I might like to just revert the previous patch entirely and rethink this. Using ARGS= in the makefile and SDKROOT= ARCHS= with build-webkit / xcodebuild, almost everything will work with the same usage as now. Mixing make variables and unparsed Xcode options in $(ARGS) or un-spliced through webkitdirs.pm doesn’t seem worth it. The only problem leftover is reducing the modules lists in Tools/Makefile and Source/Makefile, which I can shore up in a later patch.
Comment 2 David Farler 2013-01-27 03:33:37 PST
Created attachment 184909 [details]
Comment 3 WebKit Review Bot 2013-01-27 20:24:00 PST
Comment on attachment 184909 [details]

Clearing flags on attachment: 184909

Committed r140939: <http://trac.webkit.org/changeset/140939>
Comment 4 WebKit Review Bot 2013-01-27 20:24:03 PST
All reviewed patches have been landed.  Closing bug.