RESOLVED FIXED 108020
Disable -webkit-overflow-scrolling CSS attribute on Chromium
https://bugs.webkit.org/show_bug.cgi?id=108020
Summary Disable -webkit-overflow-scrolling CSS attribute on Chromium
Sami Kyöstilä
Reported 2013-01-26 19:02:12 PST
Remove -webkit-overflow-scrolling CSS attribute
Attachments
Patch (64.09 KB, patch)
2013-01-26 19:05 PST, Sami Kyöstilä
no flags
Patch (67.91 KB, patch)
2013-01-30 10:21 PST, Sami Kyöstilä
no flags
Patch (27.11 KB, patch)
2013-01-30 12:15 PST, Sami Kyöstilä
no flags
Patch (114.35 KB, patch)
2013-01-31 03:41 PST, Sami Kyöstilä
no flags
Patch (114.59 KB, patch)
2013-01-31 09:22 PST, Sami Kyöstilä
no flags
Patch (114.59 KB, patch)
2013-02-04 02:10 PST, Sami Kyöstilä
no flags
Sami Kyöstilä
Comment 1 2013-01-26 19:05:25 PST
Created attachment 184895 [details] Patch First pass to check test expectations.
Build Bot
Comment 2 2013-01-26 20:31:32 PST
Comment on attachment 184895 [details] Patch Attachment 184895 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16163009 New failing tests: compositing/overflow/scrolling-content-clip-to-viewport.html compositing/overflow/scrolling-without-painting.html compositing/overflow/updating-scrolling-content.html
WebKit Review Bot
Comment 3 2013-01-26 20:50:46 PST
Comment on attachment 184895 [details] Patch Attachment 184895 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16160031 New failing tests: platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-content-clip-to-viewport.html platform/chromium/virtual/softwarecompositing/overflow/scrolling-content-clip-to-viewport.html platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting.html compositing/overflow/scrolling-content-clip-to-viewport.html platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content.html compositing/overflow/scrolling-without-painting.html compositing/overflow/updating-scrolling-content.html
Build Bot
Comment 4 2013-01-27 21:07:25 PST
Comment on attachment 184895 [details] Patch Attachment 184895 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16150575 New failing tests: compositing/overflow/scrolling-content-clip-to-viewport.html compositing/overflow/scrolling-without-painting.html compositing/overflow/updating-scrolling-content.html
Simon Fraser (smfr)
Comment 5 2013-01-28 09:30:37 PST
I'm tempted to suggest that you leave it in but #ifdef it PLATFORM(IOS), since I'm not sure that we'll want to do automatic composited scrolling on iOS yet.
Sami Kyöstilä
Comment 6 2013-01-30 10:21:01 PST
Created attachment 185515 [details] Patch - Removed tests specific to -webkit-overflow-scroll. - Converted other composited scrolling tests to use setAcceleratedCompositingForOverflowScrollEnabled() instead. These should pass on all platforms that support accelerated compositing. - Enabled composited overflow scrolling in ScrollingCoordinatorChromiumTest.
Sami Kyöstilä
Comment 7 2013-01-30 10:28:17 PST
Ah, I missed your comment Simon. I'll do another round to leave the flag in but disable it just for Chromium. I think the tests can also be made to work in both modes.
Sami Kyöstilä
Comment 8 2013-01-30 12:15:47 PST
Created attachment 185536 [details] Patch - Only disable this on Chromium.
WebKit Review Bot
Comment 9 2013-01-30 15:02:47 PST
Comment on attachment 185536 [details] Patch Attachment 185536 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16218706 New failing tests: platform/chromium/virtual/softwarecompositing/overflow/overflow-auto-with-touch.html platform/chromium/virtual/softwarecompositing/overflow/overflow-auto-with-touch-toggle.html platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling.html compositing/overflow/nested-scrolling.html platform/chromium/virtual/softwarecompositing/overflow/overflow-overlay-with-touch.html
Sami Kyöstilä
Comment 10 2013-01-31 03:41:45 PST
Created attachment 185738 [details] Patch - Updated test expectations and baselines.
WebKit Review Bot
Comment 11 2013-01-31 09:16:17 PST
Comment on attachment 185738 [details] Patch Attachment 185738 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16282267 New failing tests: platform/chromium/virtual/softwarecompositing/overflow/overflow-auto-with-touch-toggle.html
Sami Kyöstilä
Comment 12 2013-01-31 09:22:37 PST
Created attachment 185796 [details] Patch - One more test that I missed.
Sami Kyöstilä
Comment 13 2013-01-31 11:08:01 PST
I think this is now good to go. Anyone wanna have a look?
WebKit Review Bot
Comment 14 2013-02-01 13:49:53 PST
Comment on attachment 185796 [details] Patch Rejecting attachment 185796 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 185796, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 167605 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 54>At revision 167605. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/16333105
Sami Kyöstilä
Comment 15 2013-02-04 02:10:26 PST
Created attachment 186327 [details] Patch - Rebased.
WebKit Review Bot
Comment 16 2013-02-04 06:47:18 PST
Comment on attachment 186327 [details] Patch Clearing flags on attachment: 186327 Committed r141769: <http://trac.webkit.org/changeset/141769>
WebKit Review Bot
Comment 17 2013-02-04 06:47:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.