WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
108006
Fix the test for CHANNEL_MESSAGING in idl files
https://bugs.webkit.org/show_bug.cgi?id=108006
Summary
Fix the test for CHANNEL_MESSAGING in idl files
Laszlo Gombos
Reported
2013-01-26 09:02:25 PST
I run into a test in an idl file which does not follow the "defined(ENABLE_XXX) && ENABLE_XXX" pattern for a conditional and instead it is only testing for "ENABLE_XXX". This seems the be the single place in idl files where this is the case - so this is likely a source for inconsistency and potentially a build issue.
Attachments
proposed chnage
(1.33 KB, patch)
2013-01-26 10:28 PST
,
Laszlo Gombos
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Laszlo Gombos
Comment 1
2013-01-26 10:28:06 PST
Created
attachment 184871
[details]
proposed chnage
WebKit Review Bot
Comment 2
2013-01-26 16:11:09 PST
Comment on
attachment 184871
[details]
proposed chnage Clearing flags on attachment: 184871 Committed
r140918
: <
http://trac.webkit.org/changeset/140918
>
WebKit Review Bot
Comment 3
2013-01-26 16:11:12 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug