Bug 108006 - Fix the test for CHANNEL_MESSAGING in idl files
Summary: Fix the test for CHANNEL_MESSAGING in idl files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-26 09:02 PST by Laszlo Gombos
Modified: 2013-01-26 16:11 PST (History)
4 users (show)

See Also:


Attachments
proposed chnage (1.33 KB, patch)
2013-01-26 10:28 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2013-01-26 09:02:25 PST
I run into a test in an idl file which does not follow the "defined(ENABLE_XXX) && ENABLE_XXX" pattern for a conditional and instead it is only testing for "ENABLE_XXX". This seems the be the single place in idl files where this is the case - so this is likely a source for inconsistency and potentially a build issue.
Comment 1 Laszlo Gombos 2013-01-26 10:28:06 PST
Created attachment 184871 [details]
proposed chnage
Comment 2 WebKit Review Bot 2013-01-26 16:11:09 PST
Comment on attachment 184871 [details]
proposed chnage

Clearing flags on attachment: 184871

Committed r140918: <http://trac.webkit.org/changeset/140918>
Comment 3 WebKit Review Bot 2013-01-26 16:11:12 PST
All reviewed patches have been landed.  Closing bug.