Bug 108003 – Remove code for handling NetworkProcess authentication challenges in WebProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alexey Proskuryakov]

We now send these directly to UIProcess, and a lot of code can be removed, including AuthenticationChallengeBase::m_identifier.

[Alexey Proskuryakov]

Created attachment 184857 [details]
proposed patch

[WebKit Review Bot]

Attachment 184857 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/loader/ResourceLoader.cpp', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/AuthenticationChallengeBase.h', u'Source/WebCore/platform/network/cf/AuthenticationCF.cpp', u'Source/WebCore/platform/network/cf/AuthenticationChallenge.h', u'Source/WebCore/platform/network/curl/AuthenticationChallenge.h', u'Source/WebCore/platform/network/mac/AuthenticationMac.mm', u'Source/WebCore/platform/network/qt/AuthenticationChallenge.h', u'Source/WebCore/platform/network/soup/AuthenticationChallenge.h', u'Source/WebCore/platform/network/win/AuthenticationChallenge.h', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebURLAuthenticationChallenge.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/DerivedSources.make', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.messages.in', u'Source/WebKit2/Shared/WebCoreArgumentCoders.cpp', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.h', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.messages.in']" exit_code: 1
Source/WebCore/platform/network/cf/AuthenticationCF.cpp:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/WebURLAuthenticationChallenge.cpp:151:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 184857 [details]
proposed patch

Rejecting attachment 184857 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 184857, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ct.pbxproj.rej
patching file Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp
patching file Source/WebKit2/WebProcess/Network/WebResourceLoader.h
patching file Source/WebKit2/WebProcess/Network/WebResourceLoader.messages.in
patching file Source/WebKit/win/ChangeLog
patching file Source/WebKit/win/WebURLAuthenticationChallenge.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Sam Weinig']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16153009

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r140921>.