Bug 108002 - Remove ENABLE_3D_PLUGIN
Summary: Remove ENABLE_3D_PLUGIN
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-25 22:18 PST by Laszlo Gombos
Modified: 2013-04-10 07:34 PDT (History)
8 users (show)

See Also:

Attachments
3D_PLUGIN usage (1016 bytes, patch)
2013-01-25 22:24 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
proposed change (2.28 KB, patch)
2013-04-10 06:46 PDT, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2013-01-25 22:18:08 PST 
ENABLE_3D_PLUGIN is turned on for the Chromium port (only) as a result of the following 2 commits:
 - http://trac.webkit.org/changeset/71210
 - http://trac.webkit.org/changeset/88548

It is hard for me to tell if this flag is still needed but as the flag is turned on currently for chromium removing it will result in a functional change in WebCore/loader/SubframeLoader.cpp .
Comment 1 Laszlo Gombos 2013-01-25 22:24:35 PST 
Created attachment 184856 [details]
3D_PLUGIN usage

It might very well be that this flag is needed, but I could not convince myself just yet that it is needed. It would help if someone from the chromium team could comment on this.
Comment 2 Kenneth Russell 2013-02-01 11:34:37 PST 
CC'ing jbauman. I don't know whether this is still needed for Pepper 3D, but if not then I think it's safe to remove.
Comment 3 Laszlo Gombos 2013-04-10 06:46:28 PDT 
Created attachment 197259 [details]
proposed change
Comment 4 WebKit Commit Bot 2013-04-10 07:34:31 PDT 
Comment on attachment 197259 [details]
proposed change

Clearing flags on attachment: 197259

Committed r148093: <http://trac.webkit.org/changeset/148093>
Comment 5 WebKit Commit Bot 2013-04-10 07:34:34 PDT 
All reviewed patches have been landed.  Closing bug.