Bug 107985 – [chromium] Export ResourceRequest's priority through WebURLRequest

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Simonsen]

[chromium] Export ResourceRequest's priority through WebURLRequest

[James Simonsen]

Created attachment 184812 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 184812 [details]
Patch

Attachment 184812 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16116557

[Peter Beverloo (cr-android ews)]

Comment on attachment 184812 [details]
Patch

Attachment 184812 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16118535

[James Simonsen]

Created attachment 184814 [details]
Patch

[Adam Barth]

Comment on attachment 184814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184814&action=review

> Source/WebCore/platform/chromium/support/WebURLRequest.cpp:329
> +    switch (m_private->m_resourceRequest->priority()) {

We usually just use a static_cast rather than a switch.  Also, we use AssertMatchignEnums.cpp to make sure that the WebCore enums stay in sync with the API enums.

[Adam Barth]

(Aside from those mechanistic issues, this patch looks fine.)

[James Simonsen]

Created attachment 184849 [details]
Patch

[James Simonsen]

(In reply to comment #6)
> (From update of attachment 184814 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184814&action=review
> 
> > Source/WebCore/platform/chromium/support/WebURLRequest.cpp:329
> > +    switch (m_private->m_resourceRequest->priority()) {
> 
> We usually just use a static_cast rather than a switch.  Also, we use AssertMatchignEnums.cpp to make sure that the WebCore enums stay in sync with the API enums.

Thanks for the tip. Done.

[Adam Barth]

Comment on attachment 184849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184849&action=review

> Source/WebCore/platform/chromium/support/WebURLRequest.cpp:330
> +    return static_cast<WebURLRequest::Priority>(
> +        m_private->m_resourceRequest->priority());

We'd normally put this on one line.  (There is no 80 col limit in WebKit.)

[WebKit Review Bot]

Comment on attachment 184849 [details]
Patch

Clearing flags on attachment: 184849

Committed r140906: <http://trac.webkit.org/changeset/140906>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.