Bug 107968 - Enable running tests on Windows EWS Bots
Summary: Enable running tests on Windows EWS Bots
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 108422 107969 108353
  Show dependency treegraph
Reported: 2013-01-25 11:40 PST by Lucas Forschler
Modified: 2013-02-01 12:48 PST (History)
5 users (show)

See Also:

Enable tests on Win EWS (1.12 KB, patch)
2013-01-25 11:43 PST, Lucas Forschler
no flags Details | Formatted Diff | Diff
patch for review (1.14 KB, patch)
2013-01-25 11:49 PST, Lucas Forschler
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2013-01-25 11:40:42 PST
We have more hardware in the Windows EWS queue.  Let's enable running tests and see how it does.
Comment 1 Lucas Forschler 2013-01-25 11:41:01 PST
Looking at the Win7 testers on build.webkit.org, I think we should probably get our results in shape before we enable tests.
Comment 2 Lucas Forschler 2013-01-25 11:43:53 PST
Created attachment 184784 [details]
Enable tests on Win EWS

Patch for review.
Comment 3 WebKit Review Bot 2013-01-25 11:46:58 PST
Attachment 184784 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py']" exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Lucas Forschler 2013-01-25 11:49:09 PST
Created attachment 184788 [details]
patch for review

Updated Changelog to include bug number.
Comment 5 Adam Barth 2013-01-25 17:15:19 PST
I didn't mark this cq+ because you'll likely want to be around when this lands to make sure it works.  :)
Comment 6 Tim Horton 2013-01-29 18:07:02 PST
Comment on attachment 184788 [details]
patch for review

We're all here! Let's see what happens.
Comment 7 WebKit Review Bot 2013-01-29 18:45:01 PST
Comment on attachment 184788 [details]
patch for review

Clearing flags on attachment: 184788

Committed r141205: <http://trac.webkit.org/changeset/141205>
Comment 8 WebKit Review Bot 2013-01-29 18:45:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Review Bot 2013-01-30 10:22:30 PST
Re-opened since this is blocked by bug 108353
Comment 10 WebKit Review Bot 2013-01-30 16:53:13 PST
Comment on attachment 184788 [details]
patch for review

Rejecting attachment 184788 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'validate-changelog', '--non-interactive', 184788, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16250040
Comment 11 Roger Fong 2013-01-30 17:24:54 PST
Commited: http://trac.webkit.org/changeset/141349
fingers crossed
Comment 12 WebKit Review Bot 2013-01-30 21:00:49 PST
Re-opened since this is blocked by bug 108422
Comment 13 Roger Fong 2013-02-01 12:48:54 PST
Tried again: http://trac.webkit.org/changeset/141631