Bug 107950 - [Qt][WK1] Reflect recursion limit and loop checks also for list conversions.
Summary: [Qt][WK1] Reflect recursion limit and loop checks also for list conversions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Brüning
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-25 07:13 PST by Michael Brüning
Modified: 2013-01-29 01:43 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.79 KB, patch)
2013-01-25 07:19 PST, Michael Brüning
allan.jensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Brüning 2013-01-25 07:13:21 PST
[Qt][WK1] Reflect recursion limit and loop checks als for list conversions.
Comment 1 Michael Brüning 2013-01-25 07:19:31 PST
Created attachment 184747 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-25 07:26:12 PST
Attachment 184747 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bridge/qt/qt_runtime.cpp']" exit_code: 1
Source/WebCore/bridge/qt/qt_runtime.cpp:239:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Allan Sandfeld Jensen 2013-01-29 01:34:23 PST
Comment on attachment 184747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184747&action=review

Good catch. Lists and objects need to be tracked.

> Source/WebCore/ChangeLog:3
> +        [Qt][WK1] Reflect recursion limit and loop checks als for list conversions.

typo: als->also
Comment 4 Allan Sandfeld Jensen 2013-01-29 01:34:47 PST
Comment on attachment 184747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184747&action=review

Good catch. Lists and objects need to be tracked.

> Source/WebCore/ChangeLog:3
> +        [Qt][WK1] Reflect recursion limit and loop checks als for list conversions.

typo: als->also
Comment 5 Michael Brüning 2013-01-29 01:43:16 PST
Committed r141085: <http://trac.webkit.org/changeset/141085>