RESOLVED FIXED 107950
[Qt][WK1] Reflect recursion limit and loop checks also for list conversions. 
https://bugs.webkit.org/show_bug.cgi?id=107950
Summary [Qt][WK1] Reflect recursion limit and loop checks also for list conversions.
Michael Brüning
Reported 2013-01-25 07:13:21 PST
[Qt][WK1] Reflect recursion limit and loop checks als for list conversions.
Attachments
Patch (4.79 KB, patch)
2013-01-25 07:19 PST, Michael Brüning 		allan.jensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Brüning
Comment 1 2013-01-25 07:19:31 PST
Created attachment 184747 [details] Patch
WebKit Review Bot
Comment 2 2013-01-25 07:26:12 PST
Attachment 184747 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bridge/qt/qt_runtime.cpp']" exit_code: 1 Source/WebCore/bridge/qt/qt_runtime.cpp:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Allan Sandfeld Jensen
Comment 3 2013-01-29 01:34:23 PST
Comment on attachment 184747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184747&action=review Good catch. Lists and objects need to be tracked. > Source/WebCore/ChangeLog:3 > + [Qt][WK1] Reflect recursion limit and loop checks als for list conversions. typo: als->also
Allan Sandfeld Jensen
Comment 4 2013-01-29 01:34:47 PST
Comment on attachment 184747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184747&action=review Good catch. Lists and objects need to be tracked. > Source/WebCore/ChangeLog:3 > + [Qt][WK1] Reflect recursion limit and loop checks als for list conversions. typo: als->also
Michael Brüning
Comment 5 2013-01-29 01:43:16 PST
Committed r141085: <http://trac.webkit.org/changeset/141085>
Note You need to log in before you can comment on or make changes to this bug.