Bug 107948 - [chromium] move tracking of the top loading frame to TestRunner library
Summary: [chromium] move tracking of the top loading frame to TestRunner library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-25 06:51 PST by jochen
Modified: 2013-01-25 17:33 PST (History)
6 users (show)

See Also:


Attachments
Patch (11.80 KB, patch)
2013-01-25 06:51 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (17.38 KB, patch)
2013-01-25 09:34 PST, jochen
no flags Details | Formatted Diff | Diff
Patch (17.12 KB, patch)
2013-01-25 11:33 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-01-25 06:51:23 PST
[chromium] move tracking of the top loading frame to TestRunner library
Comment 1 jochen 2013-01-25 06:51:36 PST
Created attachment 184743 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-25 06:54:40 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2013-01-25 07:11:24 PST
Comment on attachment 184743 [details]
Patch

Attachment 184743 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16123313

New failing tests:
accessibility/anchor-linked-anonymous-block-crash.html
http/tests/cache/network-error-during-revalidation.html
http/tests/cache/stopped-revalidation.html
accessibility/aria-checkbox-checked.html
animations/animation-shorthand-overriding.html
canvas/philip/tests/2d.clearRect.globalalpha.html
accessibility/aria-disabled.html
accessibility/accessibility-node-reparent.html
canvas/philip/tests/2d.clearRect.globalcomposite.html
canvas/philip/tests/2d.clearRect.clip.html
accessibility/accessibility-object-detached.html
canvas/philip/tests/2d.canvas.readonly.html
accessibility/aria-controls-with-tabs.html
http/tests/appcache/disabled.html
animations/animation-shorthand.html
http/tests/cache/post-with-cached-subresources.php
http/tests/appcache/deferred-events.html
canvas/philip/tests/2d.canvas.reference.html
accessibility/aria-describedby-on-input.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
canvas/philip/tests/2d.clearRect.basic.html
accessibility/accessibility-node-memory-management.html
animations/animation-events-create.html
animations/computed-style.html
http/tests/cache/post-redirect-get.php
animations/animation-css-rule-types.html
accessibility/adjacent-continuations-cause-assertion-failure.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
http/tests/appcache/detached-iframe.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html
Comment 4 jochen 2013-01-25 09:34:30 PST
Created attachment 184764 [details]
Patch
Comment 5 WebKit Review Bot 2013-01-25 10:26:20 PST
Comment on attachment 184764 [details]
Patch

Attachment 184764 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16110818

New failing tests:
http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/loading/progress-finished-callback.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/loading/empty-subframe.html
http/tests/loading/preload-slow-loading.php
http/tests/loading/redirect-methods.html
http/tests/loading/bad-server-subframe.html
animations/suspend-resume-animation-events.html
http/tests/loading/simple-subframe.html
http/tests/loading/307-after-303-after-post.html
http/tests/loading/onload-vs-immediate-refresh.pl
http/tests/loading/fire-error-event-script-no-content-type.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/loading/pdf-commit-load-callbacks.html
http/tests/loading/load-javascript-after-many-xhrs.html
http/tests/loading/location-hash-reload-cycle.html
http/tests/loading/slow-parsing-subframe.html
http/tests/loading/basic.html
http/tests/loading/remove-child-triggers-parser.html
http/tests/loading/state-object-security-exception.html
fast/events/touch/emulate-touch-events.html
http/tests/loading/nested_bad_objects.php
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
http/tests/loading/bad-scheme-subframe.html
http/tests/loading/redirect-with-no-location-crash.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
http/tests/loading/fire-error-event-empty-404-script.html
http/tests/loading/preload-append-scan.php
Comment 6 jochen 2013-01-25 11:33:56 PST
Created attachment 184781 [details]
Patch
Comment 7 WebKit Review Bot 2013-01-25 17:33:45 PST
Comment on attachment 184781 [details]
Patch

Clearing flags on attachment: 184781

Committed r140889: <http://trac.webkit.org/changeset/140889>
Comment 8 WebKit Review Bot 2013-01-25 17:33:50 PST
All reviewed patches have been landed.  Closing bug.