Bug 107946 - Web Inspector: Cleanup console.* API MessageSource/Levels.
Summary: Web Inspector: Cleanup console.* API MessageSource/Levels.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mike West
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2013-01-25 06:40 PST by Mike West
Modified: 2013-01-25 08:32 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.22 KB, patch)
2013-01-25 07:06 PST, Mike West 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-01-25 06:40:56 PST 
I have a few suggestions:

* console.timeEnd and console.count should both come from ConsoleAPIMessageSource.
* console.count should be DebugMessageLevel (to match console.timeEnd)
* console.profile and console.profileEnd should come from ConsoleAPIMessageSource, and be DebugMessageLevel
Comment 1 Mike West 2013-01-25 07:06:52 PST 
Created attachment 184745 [details]
Patch
Comment 2 Mike West 2013-01-25 08:27:08 PST 
Comment on attachment 184745 [details]
Patch

Thanks, Pavel.
Comment 3 WebKit Review Bot 2013-01-25 08:32:38 PST 
Comment on attachment 184745 [details]
Patch

Clearing flags on attachment: 184745

Committed r140830: <http://trac.webkit.org/changeset/140830>
Comment 4 WebKit Review Bot 2013-01-25 08:32:41 PST 
All reviewed patches have been landed.  Closing bug.