RESOLVED FIXED 107940
Web Inspector: remove unused isElement and similar methods from HeapProfiler 
https://bugs.webkit.org/show_bug.cgi?id=107940
Summary Web Inspector: remove unused isElement and similar methods from HeapProfiler
Yury Semikhatsky
Reported 2013-01-25 05:18:24 PST
Some of these methods are unused, others make sense only for JS heap snapshots. Also we can simplify filters mechanism used with node/edges providers in the heap profiler.
Attachments
Patch (15.74 KB, patch)
2013-01-25 05:25 PST, Yury Semikhatsky 		vsevik: review+
vsevik: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2013-01-25 05:25:16 PST
Created attachment 184734 [details] Patch
Ilya Tikhonovsky
Comment 2 2013-01-25 07:59:06 PST
Comment on attachment 184734 [details] Patch lgtm
Vsevolod Vlasov
Comment 3 2013-01-28 00:03:40 PST
Comment on attachment 184734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184734&action=review > Source/WebCore/inspector/front-end/JSHeapSnapshot.js:74 > + return function(edge) { { on a separate line. Maybe rewrite like this: function funcName(...) { ... } return funcName; > Source/WebCore/inspector/front-end/JSHeapSnapshot.js:78 > + return true ;
Yury Semikhatsky
Comment 4 2013-01-28 01:11:20 PST
(In reply to comment #3) > (From update of attachment 184734 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184734&action=review > > > Source/WebCore/inspector/front-end/JSHeapSnapshot.js:74 > > + return function(edge) { > > { on a separate line. > Maybe rewrite like this: > function funcName(...) > { > ... > } > > return funcName; > Done. > > Source/WebCore/inspector/front-end/JSHeapSnapshot.js:78 > > + return true > > ; Done.
Yury Semikhatsky
Comment 5 2013-01-28 01:23:33 PST
Committed r140953: <http://trac.webkit.org/changeset/140953>
Note You need to log in before you can comment on or make changes to this bug.