Bug 107940 - Web Inspector: remove unused isElement and similar methods from HeapProfiler
Summary: Web Inspector: remove unused isElement and similar methods from HeapProfiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-25 05:18 PST by Yury Semikhatsky
Modified: 2013-01-28 01:23 PST (History)
8 users (show)

See Also:


Attachments
Patch (15.74 KB, patch)
2013-01-25 05:25 PST, Yury Semikhatsky
vsevik: review+
vsevik: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-01-25 05:18:24 PST
Some of these methods are unused, others make sense only for JS heap snapshots. Also we can simplify filters mechanism used with node/edges providers in the heap profiler.
Comment 1 Yury Semikhatsky 2013-01-25 05:25:16 PST
Created attachment 184734 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-01-25 07:59:06 PST
Comment on attachment 184734 [details]
Patch

lgtm
Comment 3 Vsevolod Vlasov 2013-01-28 00:03:40 PST
Comment on attachment 184734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184734&action=review

> Source/WebCore/inspector/front-end/JSHeapSnapshot.js:74
> +        return function(edge) {

{ on a separate line.
Maybe rewrite like this:
function funcName(...)
{
 ... 
}

return funcName;

> Source/WebCore/inspector/front-end/JSHeapSnapshot.js:78
> +                return true

;
Comment 4 Yury Semikhatsky 2013-01-28 01:11:20 PST
(In reply to comment #3)
> (From update of attachment 184734 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184734&action=review
> 
> > Source/WebCore/inspector/front-end/JSHeapSnapshot.js:74
> > +        return function(edge) {
> 
> { on a separate line.
> Maybe rewrite like this:
> function funcName(...)
> {
>  ... 
> }
> 
> return funcName;
> 
Done.

> > Source/WebCore/inspector/front-end/JSHeapSnapshot.js:78
> > +                return true
> 
> ;
Done.
Comment 5 Yury Semikhatsky 2013-01-28 01:23:33 PST
Committed r140953: <http://trac.webkit.org/changeset/140953>