Bug 107938 - Refactor InspectorMemoryAgent: memory data as a map.
Summary: Refactor InspectorMemoryAgent: memory data as a map.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marja Hölttä
URL:
Keywords:
Depends on:
Blocks: 107651
  Show dependency treegraph
 
Reported: 2013-01-25 05:09 PST by Marja Hölttä
Modified: 2013-01-25 06:38 PST (History)
9 users (show)

See Also:


Attachments
Patch (11.51 KB, patch)
2013-01-25 05:12 PST, Marja Hölttä
no flags Details | Formatted Diff | Diff
Patch (11.50 KB, patch)
2013-01-25 05:13 PST, Marja Hölttä
no flags Details | Formatted Diff | Diff
Patch (11.51 KB, patch)
2013-01-25 05:34 PST, Marja Hölttä
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marja Hölttä 2013-01-25 05:09:26 PST
This will be used by bug 107651 which adds a WebKit API for accessing the memory information collected by the inspector.
Comment 1 Marja Hölttä 2013-01-25 05:12:16 PST
Created attachment 184730 [details]
Patch
Comment 2 Marja Hölttä 2013-01-25 05:13:46 PST
Created attachment 184731 [details]
Patch
Comment 3 Yury Semikhatsky 2013-01-25 05:33:01 PST
Comment on attachment 184731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184731&action=review

> Source/WebCore/inspector/InspectorController.cpp:449
> +    m_memoryAgent->getProcessMemoryDistributionAsMap(0, graph, &memoryInfo);

0 -> false
Comment 4 Marja Hölttä 2013-01-25 05:34:17 PST
Created attachment 184735 [details]
Patch
Comment 5 Marja Hölttä 2013-01-25 05:34:37 PST
Comment on attachment 184731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184731&action=review

>> Source/WebCore/inspector/InspectorController.cpp:449
>> +    m_memoryAgent->getProcessMemoryDistributionAsMap(0, graph, &memoryInfo);
> 
> 0 -> false

Oops! Fixed.
Comment 6 WebKit Review Bot 2013-01-25 06:38:53 PST
Comment on attachment 184735 [details]
Patch

Clearing flags on attachment: 184735

Committed r140823: <http://trac.webkit.org/changeset/140823>
Comment 7 WebKit Review Bot 2013-01-25 06:38:59 PST
All reviewed patches have been landed.  Closing bug.