Bug 107919 - Implement CompositionEvent constructor
Summary: Implement CompositionEvent constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 67824
  Show dependency treegraph
 
Reported: 2013-01-24 23:09 PST by Kentaro Hara
Modified: 2013-01-31 00:34 PST (History)
6 users (show)

See Also:


Attachments
Patch (19.84 KB, patch)
2013-01-24 23:11 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for landing (10.71 KB, patch)
2013-01-27 19:38 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (11.75 KB, patch)
2013-01-30 18:38 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-01-24 23:09:43 PST
We can implement a CompositionEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag.

Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
Comment 1 Kentaro Hara 2013-01-24 23:11:56 PST
Created attachment 184676 [details]
Patch
Comment 2 Kentaro Hara 2013-01-27 17:11:35 PST
Bots are green. review?
Comment 3 Sam Weinig 2013-01-27 17:42:41 PST
Comment on attachment 184676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184676&action=review

> Source/WebCore/dom/CompositionEvent.cpp:35
> +    : data()

This is not necessary.
Comment 4 Kentaro Hara 2013-01-27 19:38:04 PST
Created attachment 184931 [details]
patch for landing
Comment 5 Kentaro Hara 2013-01-27 19:38:23 PST
Comment on attachment 184931 [details]
patch for landing

Thanks sam!
Comment 6 WebKit Review Bot 2013-01-27 20:29:20 PST
Comment on attachment 184931 [details]
patch for landing

Rejecting attachment 184931 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 184931, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
it/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
LayoutTests/platform/win/TestExpectations:1216:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:394:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/efl/TestExpectations:1233:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/qt/TestExpectations:110:  Path does not exist.  [test/expectations] [5]
Total errors found: 4 in 5 files

Full output: http://queues.webkit.org/results/16152464
Comment 7 WebKit Review Bot 2013-01-27 22:29:05 PST
Comment on attachment 184931 [details]
patch for landing

Rejecting attachment 184931 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 184931, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
it/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
LayoutTests/platform/win/TestExpectations:1216:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:394:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/efl/TestExpectations:1233:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/qt/TestExpectations:110:  Path does not exist.  [test/expectations] [5]
Total errors found: 4 in 5 files

Full output: http://queues.webkit.org/results/16153531
Comment 8 WebKit Review Bot 2013-01-28 04:14:37 PST
Comment on attachment 184931 [details]
patch for landing

Rejecting attachment 184931 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 184931, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
it/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
LayoutTests/platform/win/TestExpectations:1216:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:394:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/efl/TestExpectations:1233:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/qt/TestExpectations:110:  Path does not exist.  [test/expectations] [5]
Total errors found: 4 in 5 files

Full output: http://queues.webkit.org/results/16158536
Comment 9 Kentaro Hara 2013-01-28 17:03:17 PST
Committed r141028: <http://trac.webkit.org/changeset/141028>
Comment 10 Kentaro Hara 2013-01-30 18:38:02 PST
Reopening to attach new patch.
Comment 11 Kentaro Hara 2013-01-30 18:38:08 PST
Created attachment 185653 [details]
Patch
Comment 12 Adam Barth 2013-01-31 00:13:44 PST
Comment on attachment 185653 [details]
Patch

Yay tests.
Comment 13 WebKit Review Bot 2013-01-31 00:34:53 PST
Comment on attachment 185653 [details]
Patch

Clearing flags on attachment: 185653

Committed r141386: <http://trac.webkit.org/changeset/141386>
Comment 14 WebKit Review Bot 2013-01-31 00:34:59 PST
All reviewed patches have been landed.  Closing bug.