We can implement a CompositionEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag. Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
Created attachment 184676 [details] Patch
Bots are green. review?
Comment on attachment 184676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184676&action=review > Source/WebCore/dom/CompositionEvent.cpp:35 > + : data() This is not necessary.
Created attachment 184931 [details] patch for landing
Comment on attachment 184931 [details] patch for landing Thanks sam!
Comment on attachment 184931 [details] patch for landing Rejecting attachment 184931 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 184931, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: it/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... LayoutTests/platform/win/TestExpectations:1216: Path does not exist. [test/expectations] [5] LayoutTests/platform/gtk/TestExpectations:394: Path does not exist. [test/expectations] [5] LayoutTests/platform/efl/TestExpectations:1233: Path does not exist. [test/expectations] [5] LayoutTests/platform/qt/TestExpectations:110: Path does not exist. [test/expectations] [5] Total errors found: 4 in 5 files Full output: http://queues.webkit.org/results/16152464
Comment on attachment 184931 [details] patch for landing Rejecting attachment 184931 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 184931, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: it/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... LayoutTests/platform/win/TestExpectations:1216: Path does not exist. [test/expectations] [5] LayoutTests/platform/gtk/TestExpectations:394: Path does not exist. [test/expectations] [5] LayoutTests/platform/efl/TestExpectations:1233: Path does not exist. [test/expectations] [5] LayoutTests/platform/qt/TestExpectations:110: Path does not exist. [test/expectations] [5] Total errors found: 4 in 5 files Full output: http://queues.webkit.org/results/16153531
Comment on attachment 184931 [details] patch for landing Rejecting attachment 184931 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 184931, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: it/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... LayoutTests/platform/win/TestExpectations:1216: Path does not exist. [test/expectations] [5] LayoutTests/platform/gtk/TestExpectations:394: Path does not exist. [test/expectations] [5] LayoutTests/platform/efl/TestExpectations:1233: Path does not exist. [test/expectations] [5] LayoutTests/platform/qt/TestExpectations:110: Path does not exist. [test/expectations] [5] Total errors found: 4 in 5 files Full output: http://queues.webkit.org/results/16158536
Committed r141028: <http://trac.webkit.org/changeset/141028>
Reopening to attach new patch.
Created attachment 185653 [details] Patch
Comment on attachment 185653 [details] Patch Yay tests.
Comment on attachment 185653 [details] Patch Clearing flags on attachment: 185653 Committed r141386: <http://trac.webkit.org/changeset/141386>
All reviewed patches have been landed. Closing bug.