INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
Created attachment 184675 [details] Patch
Comment on attachment 184675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184675&action=review Looks OK. > Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:97 > + DateTimeFieldElement::initialize(pseudo, axHelpText, m_minimumIndex + 1, m_maximumIndex + 1); You might want to add a comment why you are passing +1 values (if you want). That looks mysterious to strangers.
Comment on attachment 184675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184675&action=review >> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:97 >> + DateTimeFieldElement::initialize(pseudo, axHelpText, m_minimumIndex + 1, m_maximumIndex + 1); > > You might want to add a comment why you are passing +1 values (if you want). That looks mysterious to strangers. ok, I'll add a comment.
Committed r140791: <http://trac.webkit.org/changeset/140791>