Bug 107918 - INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
Summary: INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 107897
  Show dependency treegraph
 
Reported: 2013-01-24 22:58 PST by Kent Tamura
Modified: 2013-01-24 23:59 PST (History)
4 users (show)

See Also:


Attachments
Patch (8.48 KB, patch)
2013-01-24 23:09 PST, Kent Tamura
haraken: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2013-01-24 22:58:20 PST
INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
Comment 1 Kent Tamura 2013-01-24 23:09:48 PST
Created attachment 184675 [details]
Patch
Comment 2 Kentaro Hara 2013-01-24 23:18:00 PST
Comment on attachment 184675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184675&action=review

Looks OK.

> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:97
> +    DateTimeFieldElement::initialize(pseudo, axHelpText, m_minimumIndex + 1, m_maximumIndex + 1);

You might want to add a comment why you are passing +1 values (if you want). That looks mysterious to strangers.
Comment 3 Kent Tamura 2013-01-24 23:31:11 PST
Comment on attachment 184675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184675&action=review

>> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:97
>> +    DateTimeFieldElement::initialize(pseudo, axHelpText, m_minimumIndex + 1, m_maximumIndex + 1);
> 
> You might want to add a comment why you are passing +1 values (if you want). That looks mysterious to strangers.

ok, I'll add a comment.
Comment 4 Kent Tamura 2013-01-24 23:59:08 PST
Committed r140791: <http://trac.webkit.org/changeset/140791>