Bug 107912 - [TexMap] GraphicsLayerTextureMapper::setContentsNeedsDisplay() marks a ContentsDisplayChange dirty bit.
Summary: [TexMap] GraphicsLayerTextureMapper::setContentsNeedsDisplay() marks a Conten...
Status: RESOLVED DUPLICATE of bug 108312
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 107073
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-24 21:54 PST by Dongseong Hwang
Modified: 2022-06-21 20:29 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2013-01-24 21:54:29 PST 
Currently, GraphicsLayerTextureMapper::setContentsNeedsDisplay() marks a DisplayChange dirty bit.
Comment 1 Fujii Hironori 2022-06-21 20:23:48 PDT 
WinCairo WK1 is still using GraphicsLayerTextureMapper.
DisplayChange is needed to update WebGL canvas update.
If I remove the line, the following demo doesn't render as expected while mouse drugging.
https://threejs.org/examples/#webgl_geometry_teapot

diff --git a/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp b/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
index 465a57e1c558..a661cb1e3ce3 100644
--- a/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
+++ b/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
@@ -77,7 +77,6 @@ void GraphicsLayerTextureMapper::setNeedsDisplay()
 
 void GraphicsLayerTextureMapper::setContentsNeedsDisplay()
 {
-    notifyChange(DisplayChange);
     addRepaintRect(contentsRect());
 }
Comment 2 Fujii Hironori 2022-06-21 20:29:23 PDT 
I misunderstood. You suggested using ContentsDisplayChange rather than DisplayChange.
Comment 3 Fujii Hironori 2022-06-21 20:29:42 PDT 

*** This bug has been marked as a duplicate of bug 108312 ***