WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 108312
107912
[TexMap] GraphicsLayerTextureMapper::setContentsNeedsDisplay() marks a ContentsDisplayChange dirty bit.
https://bugs.webkit.org/show_bug.cgi?id=107912
Summary
[TexMap] GraphicsLayerTextureMapper::setContentsNeedsDisplay() marks a Conten...
Dongseong Hwang
Reported
2013-01-24 21:54:29 PST
Currently, GraphicsLayerTextureMapper::setContentsNeedsDisplay() marks a DisplayChange dirty bit.
Attachments
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2022-06-21 20:23:48 PDT
WinCairo WK1 is still using GraphicsLayerTextureMapper. DisplayChange is needed to update WebGL canvas update. If I remove the line, the following demo doesn't render as expected while mouse drugging.
https://threejs.org/examples/#webgl_geometry_teapot
diff --git a/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp b/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp index 465a57e1c558..a661cb1e3ce3 100644 --- a/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp +++ b/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp @@ -77,7 +77,6 @@ void GraphicsLayerTextureMapper::setNeedsDisplay() void GraphicsLayerTextureMapper::setContentsNeedsDisplay() { - notifyChange(DisplayChange); addRepaintRect(contentsRect()); }
Fujii Hironori
Comment 2
2022-06-21 20:29:23 PDT
I misunderstood. You suggested using ContentsDisplayChange rather than DisplayChange.
Fujii Hironori
Comment 3
2022-06-21 20:29:42 PDT
*** This bug has been marked as a duplicate of
bug 108312
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug