Bug 107896 - [wk2] Page overlays should do their own animation, instead of relying on implicit animation
Summary: [wk2] Page overlays should do their own animation, instead of relying on impl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-01-24 19:16 PST by Tim Horton
Modified: 2013-01-24 19:49 PST (History)
3 users (show)

See Also:

Attachments
patch (9.62 KB, patch)
2013-01-24 19:32 PST, Tim Horton 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-01-24 19:16:38 PST 
Right now, with TiledCoreAnimationDrawingArea, we accidentally depend on CA implicit animation to do the fade animation when removing a page overlay; we don't use PageOverlay's fade animation (which should be adjusted to use a CA explicit animation, but that's a bug for another day) on the way out (but we do on the way in!). We should make this consistent and update callers.

<rdar://problem/12900058>
Comment 1 Tim Horton 2013-01-24 19:32:17 PST 
Created attachment 184641 [details]
patch
Comment 2 Tim Horton 2013-01-24 19:49:02 PST 
http://trac.webkit.org/changeset/140769