WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107886
[EFL] Unreviewed build fix after
r140752
.
https://bugs.webkit.org/show_bug.cgi?id=107886
Summary
[EFL] Unreviewed build fix after r140752.
Dongseong Hwang
Reported
2013-01-24 17:31:19 PST
SSIA
Attachments
Patch
(1.66 KB, patch)
2013-01-24 17:34 PST
,
Dongseong Hwang
no flags
Details
Formatted Diff
Diff
Patch
(2.29 KB, patch)
2013-01-24 17:51 PST
,
Dongseong Hwang
no flags
Details
Formatted Diff
Diff
Patch
(2.24 KB, patch)
2013-01-24 18:46 PST
,
Dongseong Hwang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Dongseong Hwang
Comment 1
2013-01-24 17:34:13 PST
Created
attachment 184619
[details]
Patch
Dongseong Hwang
Comment 2
2013-01-24 17:46:05 PST
i need to fix some nit fit. wait plz
Dongseong Hwang
Comment 3
2013-01-24 17:51:49 PST
Created
attachment 184622
[details]
Patch
Gyuyoung Kim
Comment 4
2013-01-24 18:14:08 PST
Comment on
attachment 184622
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=184622&action=review
> Source/WebKit2/PlatformEfl.cmake:18 > + Shared/Downloads/efl/DownloadSoupErrorsEfl.cpp
Generally, uppercase is placed before lowercase. Please move this to 15 line.
Dongseong Hwang
Comment 5
2013-01-24 18:46:00 PST
Created
attachment 184634
[details]
Patch
Gyuyoung Kim
Comment 6
2013-01-24 19:05:02 PST
Comment on
attachment 184634
[details]
Patch Clearing flags on attachment: 184634 Committed
r140765
: <
http://trac.webkit.org/changeset/140765
>
Gyuyoung Kim
Comment 7
2013-01-24 19:05:10 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug