Bug 107886 - [EFL] Unreviewed build fix after r140752.
Summary: [EFL] Unreviewed build fix after r140752.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 17:31 PST by Dongseong Hwang
Modified: 2013-01-24 19:05 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2013-01-24 17:34 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Patch (2.29 KB, patch)
2013-01-24 17:51 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Patch (2.24 KB, patch)
2013-01-24 18:46 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2013-01-24 17:31:19 PST 
SSIA
Comment 1 Dongseong Hwang 2013-01-24 17:34:13 PST 
Created attachment 184619 [details]
Patch
Comment 2 Dongseong Hwang 2013-01-24 17:46:05 PST 
i need to fix some nit fit.
wait plz
Comment 3 Dongseong Hwang 2013-01-24 17:51:49 PST 
Created attachment 184622 [details]
Patch
Comment 4 Gyuyoung Kim 2013-01-24 18:14:08 PST 
Comment on attachment 184622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184622&action=review

> Source/WebKit2/PlatformEfl.cmake:18
> +    Shared/Downloads/efl/DownloadSoupErrorsEfl.cpp

Generally, uppercase is placed before lowercase. Please move this to 15 line.
Comment 5 Dongseong Hwang 2013-01-24 18:46:00 PST 
Created attachment 184634 [details]
Patch
Comment 6 Gyuyoung Kim 2013-01-24 19:05:02 PST 
Comment on attachment 184634 [details]
Patch

Clearing flags on attachment: 184634

Committed r140765: <http://trac.webkit.org/changeset/140765>
Comment 7 Gyuyoung Kim 2013-01-24 19:05:10 PST 
All reviewed patches have been landed.  Closing bug.