Bug 107876 - Abort parsing when pending location change for threaded HTML parser
Summary: Abort parsing when pending location change for threaded HTML parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-01-24 16:29 PST by Tony Gentilcore
Modified: 2013-01-25 10:06 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2013-01-24 16:31 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2013-01-24 16:29:34 PST
Abort parsing when pending location change for threaded HTML parser
Comment 1 Tony Gentilcore 2013-01-24 16:31:07 PST
Created attachment 184606 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-01-24 16:46:56 PST
Comment on attachment 184606 [details]
Patch

So this just makes us ignore the rest of this token batch.  I assume other bits cause the parser to actually stop.  It's still lame that we have to poll teh frame for this and it can't just tell us to stop!
Comment 3 Tony Gentilcore 2013-01-24 16:50:46 PST
(In reply to comment #2)
> (From update of attachment 184606 [details])
> So this just makes us ignore the rest of this token batch.  I assume other bits cause the parser to actually stop. 

Right

> It's still lame that we have to poll teh frame for this and it can't just tell us to stop!

Yeah, there's a FIXME by the other callsite. We should clean it up, but this is no worse than the main thread parser for now.
Comment 4 WebKit Review Bot 2013-01-24 22:01:17 PST
Comment on attachment 184606 [details]
Patch

Rejecting attachment 184606 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184606, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Eric Seidel']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patch: **** Can't create file /tmp/pp3gjd7X : No space left on device
patch: **** Can't create file /tmp/pplM8QPX : No space left on device

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Eric Seidel']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16097597
Comment 5 WebKit Review Bot 2013-01-25 10:06:07 PST
Comment on attachment 184606 [details]
Patch

Clearing flags on attachment: 184606

Committed r140842: <http://trac.webkit.org/changeset/140842>
Comment 6 WebKit Review Bot 2013-01-25 10:06:11 PST
All reviewed patches have been landed.  Closing bug.