RESOLVED FIXED107871
Fixing the diff_parser to correctly identify git diffs even with leading comments. 
https://bugs.webkit.org/show_bug.cgi?id=107871
Summary Fixing the diff_parser to correctly identify git diffs even with leading comm...
Tim 'mithro' Ansell
Reported 2013-01-24 15:52:37 PST
Fixing the diff_parser to correctly identify git diffs even with leading comments.
Attachments
Patch (5.85 KB, patch)
2013-01-24 15:53 PST, Tim 'mithro' Ansell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim 'mithro' Ansell
Comment 1 2013-01-24 15:53:27 PST
Created attachment 184601 [details] Patch
Eric Seidel (no email)
Comment 2 2013-01-24 20:17:19 PST
Comment on attachment 184601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184601&action=review LGTM. > Tools/Scripts/webkitpy/common/checkout/diff_parser.py:78 > # FIXME: This method belongs on DiffParser > -def get_diff_converter(first_diff_line): > +def get_diff_converter(lines): Commonly to solve this sort of testing problem, we just make an object, make this function a method, and then do: def my_free_function(foo): return MyNewObject().my_free_function(foo) I guess we just haven't gotten to that with DiffParser yet.
WebKit Review Bot
Comment 3 2013-01-24 21:07:59 PST
Comment on attachment 184601 [details] Patch Clearing flags on attachment: 184601 Committed r140775: <http://trac.webkit.org/changeset/140775>
WebKit Review Bot
Comment 4 2013-01-24 21:08:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.