Bug 107871 - Fixing the diff_parser to correctly identify git diffs even with leading comments.
Summary: Fixing the diff_parser to correctly identify git diffs even with leading comm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim 'mithro' Ansell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 15:52 PST by Tim 'mithro' Ansell
Modified: 2013-01-24 21:08 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.85 KB, patch)
2013-01-24 15:53 PST, Tim 'mithro' Ansell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim 'mithro' Ansell 2013-01-24 15:52:37 PST 
Fixing the diff_parser to correctly identify git diffs even with leading comments.
Comment 1 Tim 'mithro' Ansell 2013-01-24 15:53:27 PST 
Created attachment 184601 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-01-24 20:17:19 PST 
Comment on attachment 184601 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184601&action=review

LGTM.

> Tools/Scripts/webkitpy/common/checkout/diff_parser.py:78
>  # FIXME: This method belongs on DiffParser
> -def get_diff_converter(first_diff_line):
> +def get_diff_converter(lines):

Commonly to solve this sort of testing problem, we just make an object, make this function a method, and then do:

def my_free_function(foo):
     return MyNewObject().my_free_function(foo)

I guess we just haven't gotten to that with DiffParser yet.
Comment 3 WebKit Review Bot 2013-01-24 21:07:59 PST 
Comment on attachment 184601 [details]
Patch

Clearing flags on attachment: 184601

Committed r140775: <http://trac.webkit.org/changeset/140775>
Comment 4 WebKit Review Bot 2013-01-24 21:08:03 PST 
All reviewed patches have been landed.  Closing bug.