Bug 107865 - CertificateChain functions in ResourceResponse should be inside proper ifdefs
Summary: CertificateChain functions in ResourceResponse should be inside proper ifdefs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 14:34 PST by Pratik Solanki
Modified: 2013-01-24 15:29 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2013-01-24 14:37 PST, Pratik Solanki 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2013-01-24 14:34:38 PST 
ResourceResponse::setCertificateChain() and ResourceResponse::certificateChain() are declared inside #if PLATFORM(MAC || USE(CFNETWORK) but the definition is inside !USE(CFNETWORK). We should put it in the proper ifdef.
Comment 1 Pratik Solanki 2013-01-24 14:37:29 PST 
Created attachment 184580 [details]
Patch
Comment 2 Brady Eidson 2013-01-24 14:38:44 PST 
Comment on attachment 184580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184580&action=review

> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:192
>  
> -#endif // USE(CFNETWORK)
> +#endif

I'm sure you meant to add "// PLATFORM(MAC) || USE(CFNETWORK)"  :)
Comment 3 Pratik Solanki 2013-01-24 15:29:44 PST 
Committed r140738: <http://trac.webkit.org/changeset/140738>