Bug 107841 - [Skia] Update SkiaImageFilterBuilder's brightness matrix to match Chromium's implementation
Summary: [Skia] Update SkiaImageFilterBuilder's brightness matrix to match Chromium's ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Florin Malita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 09:51 PST by Florin Malita
Modified: 2013-01-31 09:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2013-01-24 09:56 PST, Florin Malita 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florin Malita 2013-01-24 09:51:57 PST 
After http://trac.webkit.org/changeset/139770, the brightness formula needs to be updated for both Chromium and WK/Skia.

This tracks the WK/Skia change. Corresponding Chromium CL: https://codereview.chromium.org/12033075/
Comment 1 Florin Malita 2013-01-24 09:56:32 PST 
Created attachment 184518 [details]
Patch
Comment 2 Stephen White 2013-01-24 10:19:39 PST 
Comment on attachment 184518 [details]
Patch

Looks good (bots willing).  r=me
Comment 3 WebKit Review Bot 2013-01-31 09:38:19 PST 
Comment on attachment 184518 [details]
Patch

Clearing flags on attachment: 184518

Committed r141427: <http://trac.webkit.org/changeset/141427>
Comment 4 WebKit Review Bot 2013-01-31 09:38:23 PST 
All reviewed patches have been landed.  Closing bug.