In ToT testapi.mm uses the Obj-C garbage collector, which hides a lot of our object lifetime bugs. We should enable ARC, since that is what most of our clients will be using.
<rdar://problem/13079712>
Created attachment 186456 [details] Patch
Created attachment 186483 [details] Patch
New patch that disables building with ARC on 32-bit.
Comment on attachment 186483 [details] Patch Does this compile on 32bit? You've disabled arc but still have @autoreleasepool
(In reply to comment #5) > (From update of attachment 186483 [details]) > Does this compile on 32bit? You've disabled arc but still have @autoreleasepool Yes, it builds. @autoreleasepools are unrelated to ARC.
Comment on attachment 186483 [details] Patch Clearing flags on attachment: 186483 Committed r141914: <http://trac.webkit.org/changeset/141914>
All reviewed patches have been landed. Closing bug.
Reopening because we should fix the build files so that all of the settings are in the relevant xcconfig files.
Created attachment 187177 [details] Patch
Comment on attachment 187177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187177&action=review r=me with those changes. Thanks for cleaning this up! > Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:36 > +CLANG_ENABLE_OBJC_ARC = $(CLANG_ENABLE_OBJC_ARC_$(CURRENT_ARCH)) This should have a trailing ; for consistency. > Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:39 > +CLANG_ENABLE_OBJC_ARC_ = NO; > +CLANG_ENABLE_OBJC_ARC_i386 = NO; > +CLANG_ENABLE_OBJC_ARC_ppc = NO; Since ARC defaults to off, you can omit all of these lines that explicitly set it to NO.
Committed r142184: <http://trac.webkit.org/changeset/142184>