Bug 107834 - [DumpRenderTree] Add testRunner.numberOfProgrammaticScrolls
Summary: [DumpRenderTree] Add testRunner.numberOfProgrammaticScrolls
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Knottenbelt
URL:
Keywords:
Depends on: 107026
Blocks: 107835
  Show dependency treegraph
 
Reported: 2013-01-24 09:03 PST by John Knottenbelt
Modified: 2014-04-16 17:08 PDT (History)
20 users (show)

See Also:


Attachments
Patch (13.46 KB, patch)
2013-01-24 09:07 PST, John Knottenbelt
no flags Details | Formatted Diff | Diff
Patch (15.82 KB, patch)
2013-01-25 07:12 PST, John Knottenbelt
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Knottenbelt 2013-01-24 09:03:13 PST
[DumpRenderTree] Add testRunner.numberOfProgrammaticScrolls
Comment 1 John Knottenbelt 2013-01-24 09:07:21 PST
Created attachment 184511 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-24 14:43:48 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 jochen 2013-01-24 14:59:49 PST
Comment on attachment 184511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184511&action=review

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1474
> +void WebViewHost::didProgrammaticallyScroll(const WebPoint&)

could you instead add this method to WebTestProxy, and the implementation to WebTestProxyBase.

WebTestProxyBase can then expose the value as a simple getter, and the WebViewHost::numberOfProgrammaticScrolls() would return proxy()->numberOfProgrammaticScrolls();
Comment 4 Early Warning System Bot 2013-01-24 15:22:11 PST
Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16080908
Comment 5 Early Warning System Bot 2013-01-24 16:22:41 PST
Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16084921
Comment 6 Build Bot 2013-01-24 18:52:24 PST
Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16120037
Comment 7 kov's GTK+ EWS bot 2013-01-24 19:05:17 PST
Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16112230
Comment 8 Build Bot 2013-01-24 19:51:19 PST
Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16119061
Comment 9 EFL EWS Bot 2013-01-25 00:18:55 PST
Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16113273
Comment 10 Build Bot 2013-01-25 01:31:53 PST
Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16112375
Comment 11 John Knottenbelt 2013-01-25 07:12:26 PST
Created attachment 184746 [details]
Patch
Comment 12 WebKit Review Bot 2013-01-25 07:15:19 PST
Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16097807
Comment 13 EFL EWS Bot 2013-01-25 07:16:08 PST
Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16111609
Comment 14 Build Bot 2013-01-25 07:16:19 PST
Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16114416
Comment 15 Early Warning System Bot 2013-01-25 07:17:51 PST
Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16122337
Comment 16 Peter Beverloo (cr-android ews) 2013-01-25 07:18:05 PST
Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16118380
Comment 17 Early Warning System Bot 2013-01-25 07:19:21 PST
Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16111610
Comment 18 Build Bot 2013-01-25 07:39:46 PST
Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16111618
Comment 19 Build Bot 2013-01-25 08:24:43 PST
Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16097830
Comment 20 Bem Jones-Bey 2014-04-16 17:07:46 PDT
Comment on attachment 184746 [details]
Patch

Cleaning up obviously stale bugs.