Bug 107834 – [DumpRenderTree] Add testRunner.numberOfProgrammaticScrolls

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[John Knottenbelt]

[DumpRenderTree] Add testRunner.numberOfProgrammaticScrolls

[John Knottenbelt]

Created attachment 184511 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

Comment on attachment 184511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184511&action=review

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1474
> +void WebViewHost::didProgrammaticallyScroll(const WebPoint&)

could you instead add this method to WebTestProxy, and the implementation to WebTestProxyBase.

WebTestProxyBase can then expose the value as a simple getter, and the WebViewHost::numberOfProgrammaticScrolls() would return proxy()->numberOfProgrammaticScrolls();

[Early Warning System Bot]

Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16080908

[Early Warning System Bot]

Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16084921

[Build Bot]

Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16120037

[kov's GTK+ EWS bot]

Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16112230

[Build Bot]

Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16119061

[EFL EWS Bot]

Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16113273

[Build Bot]

Comment on attachment 184511 [details]
Patch

Attachment 184511 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16112375

[John Knottenbelt]

Created attachment 184746 [details]
Patch

[WebKit Review Bot]

Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16097807

[EFL EWS Bot]

Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16111609

[Build Bot]

Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16114416

[Early Warning System Bot]

Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16122337

[Peter Beverloo (cr-android ews)]

Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16118380

[Early Warning System Bot]

Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16111610

[Build Bot]

Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16111618

[Build Bot]

Comment on attachment 184746 [details]
Patch

Attachment 184746 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16097830

[Bem Jones-Bey]

Comment on attachment 184746 [details]
Patch

Cleaning up obviously stale bugs.