Bug 107817 - Web Inspector: "XHR loaded!" messages should be DebugMessageLevel.
Summary: Web Inspector: "XHR loaded!" messages should be DebugMessageLevel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mike West
URL:
Keywords: WebExposed
Depends on:
Blocks: 97978
  Show dependency tree / graph
 
Reported: 2013-01-24 06:09 PST by Mike West
Modified: 2013-01-24 15:18 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2013-01-24 06:25 PST, Mike West 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-01-24 06:09:38 PST 
We currently allow users to opt-in to displaying messages when XHR loads successfully. These shouldn't be LogMessageLevel; that should be reserved for user-generated messages (`console.XXX()` calls).
Comment 1 Mike West 2013-01-24 06:19:03 PST 
It also shouldn't be "LogMessageType", but "NetworkMessageType". Patch in a moment.
Comment 2 Mike West 2013-01-24 06:25:49 PST 
Created attachment 184481 [details]
Patch
Comment 3 WebKit Review Bot 2013-01-24 08:02:00 PST 
Comment on attachment 184481 [details]
Patch

Rejecting attachment 184481 [details] from commit-queue.

New failing tests:
fast/repaint/selection-clear.html
Full output: http://queues.webkit.org/results/16073816
Comment 4 Mike West 2013-01-24 12:42:50 PST 
Comment on attachment 184481 [details]
Patch

It looks like the test is a flake; let's try the CQ again.
Comment 5 WebKit Review Bot 2013-01-24 15:18:51 PST 
Comment on attachment 184481 [details]
Patch

Clearing flags on attachment: 184481

Committed r140733: <http://trac.webkit.org/changeset/140733>
Comment 6 WebKit Review Bot 2013-01-24 15:18:54 PST 
All reviewed patches have been landed.  Closing bug.