Bug 107814 - Web Inspector: implement search for workspace sources
Summary: Web Inspector: implement search for workspace sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 05:41 PST by Andrey Lushnikov
Modified: 2013-01-25 03:16 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.44 KB, patch)
2013-01-24 05:46 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (4.84 KB, patch)
2013-01-24 07:55 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2013-01-24 08:01 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (5.25 KB, patch)
2013-01-24 08:12 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (5.31 KB, patch)
2013-01-25 01:31 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-01-24 05:41:02 PST 
Implement search for workspace sources.
Comment 1 Andrey Lushnikov 2013-01-24 05:46:04 PST 
Created attachment 184472 [details]
Patch
Comment 2 Pavel Feldman 2013-01-24 05:53:31 PST 
Comment on attachment 184472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184472&action=review

> Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:96
> +        function contentCallback(content, base64Encoded, mimeType)

Please annotate.

> Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:99
> +            var lines = content.split("\n");

You either need lines or lineEndings.

> Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:102
> +            for (var i = 0; i < lines.length; ++i) {

Please extract this code.
Comment 3 Andrey Lushnikov 2013-01-24 07:55:54 PST 
Created attachment 184495 [details]
Patch
Comment 4 Pavel Feldman 2013-01-24 08:01:02 PST 
Comment on attachment 184495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184495&action=review

> Source/WebCore/inspector/front-end/ContentProviders.js:291
>              callback(result);

no need for intermediate result variable.

> Source/WebCore/inspector/front-end/utilities.js:646
> +function performSearchInContent(content, query, caseSensitive, isRegex)

utilities are non-WebInspector aware. This should be defined next to WebInspector.ContentProvider.SearchMatch.
Comment 5 Andrey Lushnikov 2013-01-24 08:01:20 PST 
Created attachment 184497 [details]
Patch
Comment 6 Andrey Lushnikov 2013-01-24 08:12:29 PST 
Created attachment 184502 [details]
Patch
Comment 7 WebKit Review Bot 2013-01-24 09:10:37 PST 
Comment on attachment 184502 [details]
Patch

Rejecting attachment 184502 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 184502, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
webkit-commit-queue

Parsed 4 diffs from patch file(s).
patch: **** Can't create file /tmp/ppu5M6MG : No space left on device
patch: **** Can't create file /tmp/ppxbXQiF : No space left on device
patch: **** Can't create file /tmp/ppa1jDZE : No space left on device
patch: **** Can't create file /tmp/pp13mTbF : No space left on device

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Pavel Feldman']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16078781
Comment 8 Andrey Lushnikov 2013-01-25 01:31:19 PST 
Created attachment 184697 [details]
Patch
Comment 9 WebKit Review Bot 2013-01-25 03:16:02 PST 
Comment on attachment 184697 [details]
Patch

Clearing flags on attachment: 184697

Committed r140809: <http://trac.webkit.org/changeset/140809>
Comment 10 WebKit Review Bot 2013-01-25 03:16:06 PST 
All reviewed patches have been landed.  Closing bug.