Bug 107808 – [Soup] Streamline cancellation and client checks

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gustavo Noronha (kov)]

[Soup] Streamline cancellation and client checks

[Gustavo Noronha (kov)]

Created attachment 184459 [details]
Patch

[Martin Robinson]

Comment on attachment 184459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184459&action=review

Looks good other than the following naming nit:

> Source/WebCore/platform/network/ResourceHandle.h:169
> +    bool shouldBail();

Okay. I'm torn. I like the name shouldBail(), but something more descriptive might make it clearer why you can use the client safely after this returns false. Maybe cancelledOrClientless?

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:624
> +    ResourceHandleInternal* d = handle->getInternal();
> +    ResourceHandleClient* client = handle->client();
> +
>      ASSERT(!d->m_inputStream);

This is a bit of a micronit, but in many places in the patch, the declarations look lonely. Maybe you can staple them to the lines that actually use them before landing.

[Gustavo Noronha (kov)]

Committed r140836: <http://trac.webkit.org/changeset/140836>