[Soup] Streamline cancellation and client checks
Created attachment 184459 [details]
Comment on attachment 184459 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=184459&action=review
Looks good other than the following naming nit:
> + bool shouldBail();
Okay. I'm torn. I like the name shouldBail(), but something more descriptive might make it clearer why you can use the client safely after this returns false. Maybe cancelledOrClientless?
> + ResourceHandleInternal* d = handle->getInternal();
> + ResourceHandleClient* client = handle->client();
This is a bit of a micronit, but in many places in the patch, the declarations look lonely. Maybe you can staple them to the lines that actually use them before landing.
Committed r140836: <http://trac.webkit.org/changeset/140836>