RESOLVED FIXED Bug 107805
Web Inspector: [Canvas] REGRESSION: stack traces in the replay log are gone 
https://bugs.webkit.org/show_bug.cgi?id=107805
Summary Web Inspector: [Canvas] REGRESSION: stack traces in the replay log are gone
Andrey Adaikin
Reported 2013-01-24 02:54:25 PST
Patch to follow.
Attachments
Patch (15.18 KB, patch)
2013-01-24 03:17 PST, Andrey Adaikin 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2013-01-24 03:17:14 PST
Created attachment 184455 [details] Patch
Pavel Feldman
Comment 2 2013-01-24 04:32:46 PST
Comment on attachment 184455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184455&action=review > Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:236 > + Error.prepareStackTrace = function(error, structuredStackTrace) Error is a part of the page's context. Why do you need to intercept it?
Andrey Adaikin
Comment 3 2013-01-24 04:38:51 PST
(In reply to comment #2) > (From update of attachment 184455 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184455&action=review > > > Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:236 > > + Error.prepareStackTrace = function(error, structuredStackTrace) > > Error is a part of the page's context. Why do you need to intercept it? The canvas calls are also made from the page's context. We want the stack trace of those calls. To get it, we use V8's http://code.google.com/p/v8/wiki/JavaScriptStackTraceApi, namely Error.prepareStackTrace method.
Pavel Feldman
Comment 4 2013-01-24 05:15:22 PST
Comment on attachment 184455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184455&action=review >>> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:236 >>> + Error.prepareStackTrace = function(error, structuredStackTrace) >> >> Error is a part of the page's context. Why do you need to intercept it? > > The canvas calls are also made from the page's context. We want the stack trace of those calls. To get it, we use V8's http://code.google.com/p/v8/wiki/JavaScriptStackTraceApi, namely Error.prepareStackTrace method. We should not modify user functions if at all possible. Can we use a binding for this?
Andrey Adaikin
Comment 5 2013-01-24 06:15:56 PST
Committed r140679: <http://trac.webkit.org/changeset/140679>
Note You need to log in before you can comment on or make changes to this bug.