Bug 107803 - [Qt] Build is KO since r140610 (QString::fromUTF16 function does not exist)
Summary: [Qt] Build is KO since r140610 (QString::fromUTF16 function does not exist)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 01:35 PST by Julien Brianceau
Modified: 2013-01-24 06:31 PST (History)
3 users (show)

See Also:


Attachments
Fix Qt QString::fromUtf16() function call (1.35 KB, patch)
2013-01-24 01:51 PST, Julien Brianceau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-01-24 01:35:14 PST
Qt SH4 build slave (http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release) doesn't build since r140610

There is a typo error for QString::fromUtf16 call. It is fromUtf16 and not fromUTF16 in Qt.
Comment 1 Julien Brianceau 2013-01-24 01:51:55 PST
Created attachment 184440 [details]
Fix Qt QString::fromUtf16() function call
Comment 2 Andreas Kling 2013-01-24 01:57:44 PST
Comment on attachment 184440 [details]
Fix Qt QString::fromUtf16() function call

rs=me
Comment 3 WebKit Review Bot 2013-01-24 03:27:22 PST
Comment on attachment 184440 [details]
Fix Qt QString::fromUtf16() function call

Clearing flags on attachment: 184440

Committed r140671: <http://trac.webkit.org/changeset/140671>
Comment 4 WebKit Review Bot 2013-01-24 03:27:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Zoltan Arvai 2013-01-24 05:22:17 PST
A problem still exists with QString::fromUtf16 usage on windows bot:

http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/60904/steps/compile-webkit/logs/stdio

C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebCore\xml\parser\XMLDocumentParserQt.cpp(74) : error C2664: 'QString::fromUtf16' : cannot convert parameter 1 from 'UChar [4]' to 'const ushort *'
        Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast

Can you take a look at the conversation issue, please?
Comment 6 Martin Robinson 2013-01-24 05:59:46 PST
Sorry for the breakage. It's odd that the EWS did not catch this.
Comment 7 Zoltan Arvai 2013-01-24 06:31:04 PST
(In reply to comment #6)
> Sorry for the breakage. It's odd that the EWS did not catch this.

Maybe Win EWS uses MINGW while Qt Win bot uses MSVC for build.