Bug 107801 - The deleting Node should be detached.
Summary: The deleting Node should be detached.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 107640
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-24 01:03 PST by Hajime Morrita
Modified: 2023-01-03 13:06 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2013-01-24 01:03:51 PST 
A tracking bug which comes from Bug 107640.
In some case, Node::attached() is true even the node is deleted. 

We should be able to put ASSERT(!attached()) in ContainerNode::removeDetachedNode() but
that makes some tests fail. It should be fixed to discipline the Node lifecycle.
Comment 1 Ahmad Saleem 2023-01-03 13:04:42 PST 
Blink fixed this in following commit - https://chromium.googlesource.com/chromium/blink/+/7977c3ddb18c061e3fe161c7823c78416693580d%5E%21/#F0

Rather than asserting "attached", they did "connectedSubframeCount".

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/dom/ContainerNode.cpp#321
Comment 2 Ahmad Saleem 2023-01-03 13:06:30 PST 
(In reply to Ahmad Saleem from comment #1)
> Blink fixed this in following commit -
> https://chromium.googlesource.com/chromium/blink/+/
> 7977c3ddb18c061e3fe161c7823c78416693580d%5E%21/#F0
> 
> Rather than asserting "attached", they did "connectedSubframeCount".
> 
> WebKit Source -
> https://searchfox.org/wubkat/source/Source/WebCore/dom/ContainerNode.cpp#321

Ignore me - they have another ASSERT with 'needsAttach'.