Bug 107786 – Switch sandbox initialization back to being at initialization message time (for now)

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Sam Weinig]

Switch sandbox initialization back to being at initialization message time (for now)

[Sam Weinig]

Created attachment 184401 [details]
Patch

[Sam Weinig]

I'd like Alexey to review this.

[Alexey Proskuryakov]

Comment on attachment 184401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184401&action=review

This patch is a bit incomplete, we should delete extension handle members from WebProcessCreationParameters, and stop creating them in WebContext::createNewWebProcess().

> Source/WebKit2/Shared/SandboxInitializationParameters.h:52
> +    enum Mode {

Maybe ProfileSelectionMode?

> Source/WebKit2/WebProcess/WebProcess.cpp:250
> +    platformInitializeSandboxInitializationParameters(parameters, sandboxParameters);

That's a mouthful!

> Source/WebKit2/WebProcess/WebProcess.cpp:251
> +    initializeSandbox(sandboxParameters);

I'm not a fan of processes needing to call initializeSandbox() explicitly. Today, most of them are either not sandboxed or using custom code, but the goal is that they are all sandboxed via ChildProcess code.

Not a big deal, but adds a bit more copy/pasting.

[Alexey Proskuryakov]

I just had some realizations about high level design here, might be worth holding off landing until that settles down.

[Sam Weinig]

(In reply to comment #4)
> I just had some realizations about high level design here, might be worth holding off landing until that settles down.

Ok. Let me know when a good time is.

[Sam Weinig]

Comment on attachment 184401 [details]
Patch

On second thought, no, lets not do this at all.