Bug 107780 – Split default style-sheet statics out from StyleResolver into its own class

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Hayato Ito]

This will be a separated patch from https://bugs.webkit.org/show_bug.cgi?id=107777.

[Hayato Ito]

Created attachment 185963 [details]
Factored default style sheets

[Hayato Ito]

I am wondering whether or not we should add accessors to these static fields to encapsulate those in this case.

[Dimitri Glazkov (Google)]

Comment on attachment 185963 [details]
Factored default style sheets

View in context: https://bugs.webkit.org/attachment.cgi?id=185963&action=review

> Source/WebCore/css/CSSDefaultStyleSheets.cpp:30
> +#include "CSSDefaultStyleSheets.h"

Should this be called UserAgentStyleSheets?

[Hayato Ito]

Thank you for the review.

(In reply to comment #3)
> (From update of attachment 185963 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185963&action=review
> 
> > Source/WebCore/css/CSSDefaultStyleSheets.cpp:30
> > +#include "CSSDefaultStyleSheets.h"
> 
> Should this be called UserAgentStyleSheets?

There is already a file called UserAgentStyleSheets.h. :)

[WebKit Review Bot]

Comment on attachment 185963 [details]
Factored default style sheets

Rejecting attachment 185963 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 185963, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
cpp
patching file Source/WebCore/css/CSSDefaultStyleSheets.cpp
patching file Source/WebCore/css/CSSDefaultStyleSheets.h
patching file Source/WebCore/css/StyleResolver.cpp
Hunk #10 succeeded at 5259 (offset 13 lines).
Hunk #11 FAILED at 5320.
1 out of 11 hunks FAILED -- saving rejects to file Source/WebCore/css/StyleResolver.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Dimitri Glazkov']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16366026

[Hayato Ito]

Created attachment 186289 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 186289 [details]
Patch for landing

Clearing flags on attachment: 186289

Committed r141733: <http://trac.webkit.org/changeset/141733>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Yay!