Bug 107755 - Teach threaded HTML parser to update InspectorInstrumentation when writing HTML
Summary: Teach threaded HTML parser to update InspectorInstrumentation when writing HTML
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency tree / graph
 
Reported: 2013-01-23 16:23 PST by Tony Gentilcore
Modified: 2013-01-23 18:18 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.88 KB, patch)
2013-01-23 16:24 PST, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Patch (2.88 KB, patch)
2013-01-23 16:54 PST, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2013-01-23 16:23:29 PST 
Teach threaded HTML parser to update InspectorInstrumentation when writing HTML
Comment 1 Tony Gentilcore 2013-01-23 16:24:53 PST 
Created attachment 184338 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-01-23 16:42:25 PST 
Comment on attachment 184338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184338&action=review

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:284
> +    InspectorInstrumentationCookie cookie = InspectorInstrumentation::willWriteHTML(document(), 0, 0);

We have the line number, we could easily pass it here. :)

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:313
> +    InspectorInstrumentation::didWriteHTML(cookie, 0);

Similarly here, lineNumber() should just be correct already. :)
Comment 3 Tony Gentilcore 2013-01-23 16:54:09 PST 
Created attachment 184350 [details]
Patch
Comment 4 Tony Gentilcore 2013-01-23 16:57:05 PST 
> Similarly here, lineNumber() should just be correct already. :)

You are right. Fixed.
Comment 5 Eric Seidel (no email) 2013-01-23 16:59:25 PST 
Comment on attachment 184350 [details]
Patch

LGTM.  It would be easy to wire the input length into the "packets of tokens" sent back from the background parser, but we can do that in a second pass.
Comment 6 WebKit Review Bot 2013-01-23 18:18:53 PST 
Comment on attachment 184350 [details]
Patch

Clearing flags on attachment: 184350

Committed r140628: <http://trac.webkit.org/changeset/140628>
Comment 7 WebKit Review Bot 2013-01-23 18:18:56 PST 
All reviewed patches have been landed.  Closing bug.