Bug 107752 – [CSS Regions] Selecting text inside an empty region causes selection outside the region area

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Zoltan Horvath]

Created attachment 184333 [details]
test case

Selecting text inside an empty region causes selection outside the region area.

Open the testfile and make a selection inside the blue rectangle, the selection will appear on the text of the #rectangle block.

[Mihnea Ovidenie]

Created attachment 192386 [details]
Patch

[Build Bot]

Comment on attachment 192386 [details]
Patch

Attachment 192386 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17130326

New failing tests:
fast/css/sticky/sticky-both-sides.html

[WebKit Review Bot]

Comment on attachment 192386 [details]
Patch

Attachment 192386 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17114293

New failing tests:
fast/repaint/japanese-rl-selection-repaint-in-regions.html

[Mihnea Ovidenie]

Created attachment 192882 [details]
Patch 2

Updated patch, the failure will be fixed part of: https://bugs.webkit.org/show_bug.cgi?id=106097

[Dave Hyatt]

Comment on attachment 192882 [details]
Patch 2

r=me

[Dave Hyatt]

This is kind of weird. I'll r+ it, but it would probably be better to keep hit testing from going outside of the flow thread in the first place.

[Mihnea Ovidenie]

Created attachment 193247 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 193247 [details]
Patch for landing

Clearing flags on attachment: 193247

Committed r145884: <http://trac.webkit.org/changeset/145884>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.