Bug 107752 - [CSS Regions] Selecting text inside an empty region causes selection outside the region area
Summary: [CSS Regions] Selecting text inside an empty region causes selection outside ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihnea Ovidenie
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2013-01-23 15:47 PST by Zoltan Horvath
Modified: 2013-03-15 01:10 PDT (History)
10 users (show)

See Also:

Attachments
test case (1.76 KB, text/html)
2013-01-23 15:47 PST, Zoltan Horvath 		no flags Details
Patch (5.69 KB, patch)
2013-03-10 14:19 PDT, Mihnea Ovidenie 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch 2 (5.67 KB, patch)
2013-03-13 01:52 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
Patch for landing (6.06 KB, patch)
2013-03-15 00:17 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-01-23 15:47:46 PST 
Created attachment 184333 [details]
test case

Selecting text inside an empty region causes selection outside the region area.

Open the testfile and make a selection inside the blue rectangle, the selection will appear on the text of the #rectangle block.
Comment 1 Mihnea Ovidenie 2013-03-10 14:19:42 PDT 
Created attachment 192386 [details]
Patch
Comment 2 Build Bot 2013-03-10 14:52:14 PDT 
Comment on attachment 192386 [details]
Patch

Attachment 192386 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17130326

New failing tests:
fast/css/sticky/sticky-both-sides.html
Comment 3 WebKit Review Bot 2013-03-10 17:01:15 PDT 
Comment on attachment 192386 [details]
Patch

Attachment 192386 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17114293

New failing tests:
fast/repaint/japanese-rl-selection-repaint-in-regions.html
Comment 4 Mihnea Ovidenie 2013-03-13 01:52:08 PDT 
Created attachment 192882 [details]
Patch 2

Updated patch, the failure will be fixed part of: https://bugs.webkit.org/show_bug.cgi?id=106097
Comment 5 Dave Hyatt 2013-03-13 13:11:58 PDT 
Comment on attachment 192882 [details]
Patch 2

r=me
Comment 6 Dave Hyatt 2013-03-13 13:12:24 PDT 
This is kind of weird. I'll r+ it, but it would probably be better to keep hit testing from going outside of the flow thread in the first place.
Comment 7 Mihnea Ovidenie 2013-03-15 00:17:57 PDT 
Created attachment 193247 [details]
Patch for landing
Comment 8 WebKit Review Bot 2013-03-15 01:10:25 PDT 
Comment on attachment 193247 [details]
Patch for landing

Clearing flags on attachment: 193247

Committed r145884: <http://trac.webkit.org/changeset/145884>
Comment 9 WebKit Review Bot 2013-03-15 01:10:30 PDT 
All reviewed patches have been landed.  Closing bug.