Bug 107746 - Convert RenderFullScreen to use the non-deprecated flexbox
Summary: Convert RenderFullScreen to use the non-deprecated flexbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Christian Biesinger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 15:16 PST by Christian Biesinger
Modified: 2013-01-24 12:18 PST (History)
10 users (show)

See Also:

Attachments
Patch (3.13 KB, patch)
2013-01-23 15:18 PST, Christian Biesinger 		no flags Details | Formatted Diff | Diff
Patch (14.03 KB, patch)
2013-01-23 16:42 PST, Christian Biesinger 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Biesinger 2013-01-23 15:16:48 PST 
Convert RenderFullScreen to use the non-deprecated flexbox
Comment 1 Christian Biesinger 2013-01-23 15:18:52 PST 
Created attachment 184325 [details]
Patch
Comment 2 Christian Biesinger 2013-01-23 16:42:48 PST 
Created attachment 184345 [details]
Patch
Comment 3 Christian Biesinger 2013-01-23 16:43:17 PST 
new patch also updates the fullscreen-related css/*.css files
Comment 4 Ojan Vafai 2013-01-23 23:11:28 PST 
Comment on attachment 184345 [details]
Patch

Are none of the fullscreen tests render tree dumps? I'd expect some render tree dumps to change here.
Comment 5 Christian Biesinger 2013-01-24 11:59:31 PST 
Some (a minority) are render dumps... but I don't see any RenderDeprecatedFlexBox in those dumps, e.g.:
http://trac.webkit.org/browser/trunk/LayoutTests/fullscreen/full-screen-render-inline-expected.txt

Maybe the ones that do have a render dump don't dump during full screen?
Comment 6 WebKit Review Bot 2013-01-24 12:18:08 PST 
Comment on attachment 184345 [details]
Patch

Clearing flags on attachment: 184345

Committed r140705: <http://trac.webkit.org/changeset/140705>
Comment 7 WebKit Review Bot 2013-01-24 12:18:11 PST 
All reviewed patches have been landed.  Closing bug.