Bug 107733 - [Freetype] Synthetic bold not applied to fallback fonts properly
Summary: [Freetype] Synthetic bold not applied to fallback fonts properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 13:59 PST by Martin Robinson
Modified: 2013-01-28 07:36 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.03 MB, patch)
2013-01-23 16:18 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-01-23 13:59:53 PST 
When a font falls back per-character synthetic bold fails to apply properly. This is apparent by observing fast/text/international/bold-bengali.html.
Comment 1 Martin Robinson 2013-01-23 16:18:14 PST 
Created attachment 184337 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-23 16:22:56 PST 
Attachment 184337 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/gtk/fast/css/font-face-multiple-faces-expected.png', u'LayoutTests/platform/gtk/fast/css/font-face-synthetic-bold-italic-expected.png', u'LayoutTests/platform/gtk/fast/dom/34176-expected.png', u'LayoutTests/platform/gtk/fast/encoding/denormalised-voiced-japanese-chars-expected.png', u'LayoutTests/platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.png', u'LayoutTests/platform/gtk/fast/text/cg-fallback-bolding-expected.png', u'LayoutTests/platform/gtk/fast/text/fallback-traits-fixup-expected.png', u'LayoutTests/platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.png', u'LayoutTests/platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.png', u'LayoutTests/platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.png', u'LayoutTests/platform/gtk/fast/text/international/bold-bengali-expected.png', u'LayoutTests/platform/gtk/fast/text/international/khmer-selection-expected.png', u'LayoutTests/platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp']" exit_code: 1
LayoutTests/platform/gtk/fast/text/international/bold-bengali-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2013-01-28 07:36:43 PST 
Comment on attachment 184337 [details]
Patch

Clearing flags on attachment: 184337

Committed r140967: <http://trac.webkit.org/changeset/140967>
Comment 4 WebKit Review Bot 2013-01-28 07:36:46 PST 
All reviewed patches have been landed.  Closing bug.