Bug 107727 – [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

Tamil and Bengali characters often fall back to the fonts-freefonts fonts (FreeSans and the like). We should add these to the webkitgtk-test-fonts package as they can affect test results.

[Martin Robinson]

Created attachment 184300 [details]
Patch

[WebKit Review Bot]

Attachment 184300 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/gtk/fast/text/atsui-multiple-renderers-expected.png', u'LayoutTests/platform/gtk/fast/text/atsui-multiple-renderers-expected.txt', u'LayoutTests/platform/gtk/fast/text/complex-text-opacity-expected.png', u'LayoutTests/platform/gtk/fast/text/complex-text-opacity-expected.txt', u'LayoutTests/platform/gtk/fast/text/international/bold-bengali-expected.png', u'LayoutTests/platform/gtk/fast/text/international/bold-bengali-expected.txt', u'LayoutTests/platform/gtk/fast/text/international/complex-character-based-fallback-expected.png', u'LayoutTests/platform/gtk/fast/text/international/complex-character-based-fallback-expected.txt', u'LayoutTests/platform/gtk/fast/text/international/danda-space-expected.png', u'LayoutTests/platform/gtk/fast/text/international/danda-space-expected.txt', u'LayoutTests/platform/gtk/fast/text/international/hindi-spacing-expected.png', u'LayoutTests/platform/gtk/fast/text/international/hindi-spacing-expected.txt', u'LayoutTests/platform/gtk/fast/text/international/hindi-whitespace-expected.png', u'LayoutTests/platform/gtk/fast/text/international/hindi-whitespace-expected.txt', u'LayoutTests/platform/gtk/fast/text/international/thai-baht-space-expected.png', u'LayoutTests/platform/gtk/fast/text/international/thai-baht-space-expected.txt', u'LayoutTests/platform/gtk/fast/text/international/thai-line-breaks-expected.png', u'LayoutTests/platform/gtk/fast/text/international/thai-line-breaks-expected.txt', u'LayoutTests/platform/gtk/svg/text/non-bmp-positioning-lists-expected.png', u'LayoutTests/platform/gtk/svg/text/non-bmp-positioning-lists-expected.txt', u'LayoutTests/platform/gtk/transforms/2d/hindi-rotated-expected.png', u'LayoutTests/platform/gtk/transforms/2d/hindi-rotated-expected.txt', u'Tools/ChangeLog', u'Tools/gtk/jhbuild.modules']" exit_code: 1
LayoutTests/platform/gtk/fast/text/atsui-multiple-renderers-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gustavo Noronha (kov)]

Comment on attachment 184300 [details]
Patch

LGTM

[WebKit Review Bot]

Comment on attachment 184300 [details]
Patch

Clearing flags on attachment: 184300

Committed r140599: <http://trac.webkit.org/changeset/140599>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.